tests/compiler/dart2js_native/native_named_constructors3_frog_test.dart - Issue 2990083002: dart2js_native tests: Migrate 'native STRING' to JS-calls - part 2/2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js_native/native_named_constructors3_frog_test.dart

Issue 2990083002: dart2js_native tests: Migrate 'native STRING' to JS-calls - part 2/2 (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tests/compiler/dart2js_native/native_named_constructors2_frog_test.dart ('K') | « tests/compiler/dart2js_native/native_named_constructors2_frog_test.dart ('k') | tests/compiler/dart2js_native/static_methods_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/compiler/dart2js_native/native_named_constructors3_frog_test.dart

diff --git a/tests/compiler/dart2js_native/native_named_constructors3_frog_test.dart b/tests/compiler/dart2js_native/native_named_constructors3_frog_test.dart

index 20debda492612c7bc53154acc6cdad5e2bb933fc..5ae7af87cf3da4a8b0522b71694dc90a0ae9464e 100644

--- a/tests/compiler/dart2js_native/native_named_constructors3_frog_test.dart

+++ b/tests/compiler/dart2js_native/native_named_constructors3_frog_test.dart

@@ -16,7 +16,9 @@ class A {

factory A.fromString(String s) => makeA(s.length);

// Only functions with zero parameters are allowed with "native r'...'".

Siggi Cherem (dart-lang) 2017/07/31 21:51:11 ditto

sra1 2017/07/31 22:11:30 Done.

- factory A.nativeConstructor() native r'return makeA(102);';

+ factory A.nativeConstructor() {

+ return JS('A|Null', 'makeA(102)');

+ }

foo() native;

}