Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: tests/compiler/dart2js_native/native_named_constructors2_frog_test.dart

Issue 2990083002: dart2js_native tests: Migrate 'native STRING' to JS-calls - part 2/2 (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js_native/native_named_constructors2_frog_test.dart
diff --git a/tests/compiler/dart2js_native/native_named_constructors2_frog_test.dart b/tests/compiler/dart2js_native/native_named_constructors2_frog_test.dart
index 5a02a3b116c396e0d7391da3d20c32f2ab912729..2d8cd5c0b56484726287f14af982c7a6a1f3d1c5 100644
--- a/tests/compiler/dart2js_native/native_named_constructors2_frog_test.dart
+++ b/tests/compiler/dart2js_native/native_named_constructors2_frog_test.dart
@@ -13,7 +13,9 @@ class A {
factory A.fromString(String s) => _construct(s.length);
// Only functions with zero parameters are allowed with "native r'...'".
- factory A.nativeConstructor() native r'return makeA(102);';
+ factory A.nativeConstructor() {
Siggi Cherem (dart-lang) 2017/07/31 21:51:11 might be worth updating the comment above - from h
sra1 2017/07/31 22:11:30 Done.
+ return JS('A|Null', 'makeA(102)');
+ }
static A _construct(v) {
return makeA(v);

Powered by Google App Engine
This is Rietveld 408576698