Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2990083002: dart2js_native tests: Migrate 'native STRING' to JS-calls - part 2/2 (Closed)

Created:
3 years, 4 months ago by sra1
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js_native tests: Migrate 'native STRING' to JS-calls - part 2/2 BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/0c4624202340b3f38d6cf8f3793ac84e30afebe0

Patch Set 1 #

Total comments: 4

Patch Set 2 : remove defunct comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+478 lines, -389 lines) Patch
M tests/compiler/dart2js_native/bound_closure_test.dart View 1 chunk +21 lines, -18 lines 0 comments Download
M tests/compiler/dart2js_native/browser_compat_1_prepatched_test.dart View 1 chunk +37 lines, -34 lines 0 comments Download
M tests/compiler/dart2js_native/browser_compat_1_unpatched_test.dart View 1 chunk +39 lines, -36 lines 0 comments Download
M tests/compiler/dart2js_native/browser_compat_2_test.dart View 4 chunks +16 lines, -13 lines 0 comments Download
M tests/compiler/dart2js_native/dispatch_property_initialization_test.dart View 1 chunk +9 lines, -6 lines 0 comments Download
M tests/compiler/dart2js_native/error_safeToString_test.dart View 1 chunk +43 lines, -40 lines 0 comments Download
M tests/compiler/dart2js_native/event_loop_test.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/fake_thing_2_test.dart View 1 chunk +14 lines, -11 lines 0 comments Download
M tests/compiler/dart2js_native/fake_thing_test.dart View 1 chunk +9 lines, -6 lines 0 comments Download
M tests/compiler/dart2js_native/fixup_get_tag_test.dart View 1 chunk +27 lines, -24 lines 0 comments Download
M tests/compiler/dart2js_native/issue9182_test.dart View 1 chunk +8 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/jsobject_test.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_fields_2_test.dart View 1 chunk +21 lines, -18 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_fields_3_test.dart View 1 chunk +35 lines, -32 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_fields_test.dart View 2 chunks +6 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_inheritance4_frog_test.dart View 1 chunk +21 lines, -18 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_name_test.dart View 1 chunk +25 lines, -22 lines 0 comments Download
M tests/compiler/dart2js_native/native_method_inlining_test.dart View 1 chunk +23 lines, -20 lines 0 comments Download
M tests/compiler/dart2js_native/native_named_constructors2_frog_test.dart View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_named_constructors3_frog_test.dart View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/static_methods_test.dart View 1 chunk +12 lines, -9 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_1_test.dart View 1 chunk +15 lines, -12 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_2_test.dart View 1 chunk +11 lines, -8 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_3_test.dart View 1 chunk +9 lines, -6 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_4_test.dart View 1 chunk +8 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_5_test.dart View 1 chunk +8 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_constructor_1_test.dart View 1 chunk +8 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_super_call_test.dart View 1 chunk +12 lines, -9 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_super_field_1_test.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_super_field_2_test.dart View 1 chunk +9 lines, -6 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_type_test.dart View 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sra1
3 years, 4 months ago (2017-07-31 21:39:09 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2990083002/diff/1/tests/compiler/dart2js_native/native_named_constructors2_frog_test.dart File tests/compiler/dart2js_native/native_named_constructors2_frog_test.dart (right): https://codereview.chromium.org/2990083002/diff/1/tests/compiler/dart2js_native/native_named_constructors2_frog_test.dart#newcode16 tests/compiler/dart2js_native/native_named_constructors2_frog_test.dart:16: factory A.nativeConstructor() { might be worth updating the ...
3 years, 4 months ago (2017-07-31 21:51:11 UTC) #3
sra1
https://codereview.chromium.org/2990083002/diff/1/tests/compiler/dart2js_native/native_named_constructors2_frog_test.dart File tests/compiler/dart2js_native/native_named_constructors2_frog_test.dart (right): https://codereview.chromium.org/2990083002/diff/1/tests/compiler/dart2js_native/native_named_constructors2_frog_test.dart#newcode16 tests/compiler/dart2js_native/native_named_constructors2_frog_test.dart:16: factory A.nativeConstructor() { On 2017/07/31 21:51:11, Siggi Cherem (dart-lang) ...
3 years, 4 months ago (2017-07-31 22:11:30 UTC) #4
sra1
3 years, 4 months ago (2017-07-31 22:14:59 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
0c4624202340b3f38d6cf8f3793ac84e30afebe0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698