Issue 299003004: Fix leak in GpuChannel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 299003004: Fix leak in GpuChannel (Closed)

Created:
6 years, 7 months ago by piman

Modified:
6 years, 7 months ago

Reviewers:
no sievers

CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix leak in GpuChannel There may be remaining messages in the deferred queue on unclean teardown. Delete those. Also, a little bit of cleanup in the area: - GpuChannel doesn't need to be refcounted - It's ok to copy WeakPtr across threads, as long as they're only dereferenced on the thread that the factory is destroyed. So no need for the extra indirection. BUG=374843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272584

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -60 lines)			Patch
M	content/common/gpu/gpu_channel.h	View	4 chunks	+2 lines, -10 lines	0 comments	Download
M	content/common/gpu/gpu_channel.cc	View	10 chunks	+21 lines, -40 lines	0 comments	Download
M	content/common/gpu/gpu_channel_manager.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/common/gpu/gpu_channel_manager.cc	View	3 chunks	+5 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

no sievers

LGTM. Yea that WeakPtr handling looks like it's from before WeakPtr itself supported being deleted ...

6 years, 7 months ago (2014-05-23 18:07:03 UTC) #2

no sievers

LGTM. Yea that WeakPtr handling looks like it's from before WeakPtr itself supported being deleted ...

6 years, 7 months ago (2014-05-23 18:07:04 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/299003004/1

6 years, 7 months ago (2014-05-23 18:12:00 UTC) #5

Message was sent while issue was closed.

Change committed as 272584

Expand Messages | Collapse Messages