Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 299003002: ServiceWorker: support Response.{status,statusText,headers} [chromium] (1/3) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/common/service_worker/service_worker_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_browsertest.cc
diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc
index 9b32308834d8ab6af7025470268d24cf63fe0136..74d05ff0c4592019d211f31b02d6286841929de8 100644
--- a/content/browser/service_worker/service_worker_browsertest.cc
+++ b/content/browser/service_worker/service_worker_browsertest.cc
@@ -463,15 +463,19 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest,
SERVICE_WORKER_ERROR_INSTALL_WORKER_FAILED);
}
-IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest, FetchEvent_Response) {
+// TODO(kinuko): Re-enable thist test once blink-side patch is rolled for
jsbell 2014/05/23 21:05:06 typo: 'thist'
kinuko 2014/05/26 02:35:48 Done.
+// http://crbug.com/376733
+IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest,
+ DISABLED_FetchEvent_Response) {
ServiceWorkerFetchEventResult result;
ServiceWorkerResponse response;
FetchTestHelper("/service_worker/fetch_event.js", &result, &response);
ASSERT_EQ(SERVICE_WORKER_FETCH_EVENT_RESULT_RESPONSE, result);
- EXPECT_EQ(200, response.status_code);
- EXPECT_EQ("OK", response.status_text);
- EXPECT_EQ("GET", response.method);
+ EXPECT_EQ(301, response.status_code);
+ EXPECT_EQ("Moved Permently", response.status_text);
falken 2014/05/24 14:49:51 typo "Permently"
kinuko 2014/05/26 02:35:48 Oops... done.
std::map<std::string, std::string> expected_headers;
+ expected_headers["Content-Language"] = "fi";
+ expected_headers["Content-Type"] = "text/html; charset=UTF-8";
EXPECT_EQ(expected_headers, response.headers);
}
@@ -509,7 +513,10 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest,
ASSERT_EQ(SERVICE_WORKER_ERROR_ABORT, status);
}
-IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest, SyncEventHandled) {
+// TODO(kinuko): Re-enable thist test once blink-side patch is rolled for
jsbell 2014/05/23 21:05:06 typo: 'thist'
kinuko 2014/05/26 02:35:48 Done.
+// http://crbug.com/376733
+IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest,
+ DISABLED_SyncEventHandled) {
CommandLine* command_line = CommandLine::ForCurrentProcess();
command_line->AppendSwitch(switches::kEnableServiceWorkerSync);
« no previous file with comments | « no previous file | content/common/service_worker/service_worker_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698