ServiceWorker: support Response.{status,statusText,headers} [chromium] (1/3)

ServiceWorker: support Response.{status,statusText,headers} [chromium] (1/3)

Multi-sided patch:
1/3: chromium-side, THIS PATCH
2/3: blink-side, https://codereview.chromium.org/287363004/
3/3: chromium-side, cleanup & re-enable test (n/a yet)

BUG=376733
TEST=LayoutTests is to be added, content_browsertests is to be re-enabled
TBR=tsepez@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272865

[kinuko, 2014-05-23 13:08:22]

PTL (probably you'll want to review the 2nd blink-side patch first)

[jsbell, 2014-05-23 21:05:06]

lgtm

https://codereview.chromium.org/299003002/diff/20001/content/browser/service_...
File content/browser/service_worker/service_worker_browsertest.cc (right):

https://codereview.chromium.org/299003002/diff/20001/content/browser/service_...
content/browser/service_worker/service_worker_browsertest.cc:466: //
TODO(kinuko): Re-enable thist test once blink-side patch is rolled for
typo: 'thist'

https://codereview.chromium.org/299003002/diff/20001/content/browser/service_...
content/browser/service_worker/service_worker_browsertest.cc:516: //
TODO(kinuko): Re-enable thist test once blink-side patch is rolled for
typo: 'thist'

[falken, 2014-05-24 14:49:51]

lgtm2

https://codereview.chromium.org/299003002/diff/20001/content/browser/service_...
File content/browser/service_worker/service_worker_browsertest.cc (right):

https://codereview.chromium.org/299003002/diff/20001/content/browser/service_...
content/browser/service_worker/service_worker_browsertest.cc:475:
EXPECT_EQ("Moved Permently", response.status_text);
typo "Permently"

[kinuko, 2014-05-26 02:35:48]

Thanks, updated.

https://codereview.chromium.org/299003002/diff/20001/content/browser/service_...
File content/browser/service_worker/service_worker_browsertest.cc (right):

https://codereview.chromium.org/299003002/diff/20001/content/browser/service_...
content/browser/service_worker/service_worker_browsertest.cc:466: //
TODO(kinuko): Re-enable thist test once blink-side patch is rolled for
On 2014/05/23 21:05:06, jsbell wrote:
> typo: 'thist'

Done.

https://codereview.chromium.org/299003002/diff/20001/content/browser/service_...
content/browser/service_worker/service_worker_browsertest.cc:475:
EXPECT_EQ("Moved Permently", response.status_text);
On 2014/05/24 14:49:51, falken wrote:
> typo "Permently"

Oops... done.

https://codereview.chromium.org/299003002/diff/20001/content/browser/service_...
content/browser/service_worker/service_worker_browsertest.cc:516: //
TODO(kinuko): Re-enable thist test once blink-side patch is rolled for
On 2014/05/23 21:05:06, jsbell wrote:
> typo: 'thist'

Done.

[kinuko, 2014-05-26 02:35:56]

The CQ bit was checked by kinuko@chromium.org

[kinuko, 2014-05-26 02:35:59]

The CQ bit was unchecked by kinuko@chromium.org

[kinuko, 2014-05-26 02:36:40]

+@tsepez, could you review service_worker_messages.h change?

[kinuko, 2014-05-26 02:40:42]

On 2014/05/26 02:36:40, kinuko wrote:
> +@tsepez, could you review service_worker_messages.h change?

Actually it's just deleting one field, could we land it with TBR? (Please feel
free to uncheck CQ or revert if you look anything suspicious-- thanks.)

[kinuko, 2014-05-26 02:40:53]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2014-05-26 02:41:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kinuko@chromium.org/299003002/40001

[kinuko, 2014-05-26 04:37:16]

The CQ bit was unchecked by kinuko@chromium.org

[kinuko, 2014-05-26 04:38:51]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2014-05-26 04:39:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kinuko@chromium.org/299003002/60001

[commit-bot: I haz the power, 2014-05-26 06:28:33]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-26 06:48:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-26 06:48:03]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[kinuko, 2014-05-26 07:52:47]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2014-05-26 07:53:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kinuko@chromium.org/299003002/60001

[commit-bot: I haz the power, 2014-05-26 19:27:58]

Change committed as 272865