Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: runtime/vm/timeline.cc

Issue 2990023002: Fixes build for uninitialized local variable. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/globals.h" 5 #include "platform/globals.h"
6 #ifndef PRODUCT 6 #ifndef PRODUCT
7 7
8 #include "vm/timeline.h" 8 #include "vm/timeline.h"
9 9
10 #include <errno.h> 10 #include <errno.h>
(...skipping 1695 matching lines...) Expand 10 before | Expand all | Expand 10 after
1706 int64_t type, 1706 int64_t type,
1707 int64_t flow_id, 1707 int64_t flow_id,
1708 const char* args) { 1708 const char* args) {
1709 const int64_t pid = OS::ProcessId(); 1709 const int64_t pid = OS::ProcessId();
1710 OSThread* os_thread = thread->os_thread(); 1710 OSThread* os_thread = thread->os_thread();
1711 ASSERT(os_thread != NULL); 1711 ASSERT(os_thread != NULL);
1712 const int64_t tid = OSThread::ThreadIdToIntPtr(os_thread->trace_id()); 1712 const int64_t tid = OSThread::ThreadIdToIntPtr(os_thread->trace_id());
1713 1713
1714 TimelineEvent::EventType event_type = 1714 TimelineEvent::EventType event_type =
1715 static_cast<TimelineEvent::EventType>(type); 1715 static_cast<TimelineEvent::EventType>(type);
1716 const char* typestr; 1716 const char* typestr = NULL;
1717 const char* bpstr = ""; 1717 const char* bpstr = "";
1718 switch (event_type) { 1718 switch (event_type) {
1719 case TimelineEvent::kFlowBegin: 1719 case TimelineEvent::kFlowBegin:
1720 typestr = "s"; 1720 typestr = "s";
1721 break; 1721 break;
1722 case TimelineEvent::kFlowStep: 1722 case TimelineEvent::kFlowStep:
1723 typestr = "t"; 1723 typestr = "t";
1724 break; 1724 break;
1725 case TimelineEvent::kFlowEnd: 1725 case TimelineEvent::kFlowEnd:
1726 typestr = "f"; 1726 typestr = "f";
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
1767 name, category, tid, pid, start, args); 1767 name, category, tid, pid, start, args);
1768 1768
1769 event->Instant("", start); 1769 event->Instant("", start);
1770 // json was allocated in the zone and a copy will be stored in event. 1770 // json was allocated in the zone and a copy will be stored in event.
1771 event->CompleteWithPreSerializedJSON(json); 1771 event->CompleteWithPreSerializedJSON(json);
1772 } 1772 }
1773 1773
1774 } // namespace dart 1774 } // namespace dart
1775 1775
1776 #endif // !PRODUCT 1776 #endif // !PRODUCT
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698