Issue 2990003002: update fasta parser compatibility tests to check error codes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2990003002: update fasta parser compatibility tests to check error codes (Closed)

Created:
3 years, 4 months ago by danrubel

Modified:
3 years, 4 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

update fasta parser compatibility tests to check error codes This updates the analyzer parser compatibility tests to check for error codes. Any test that was passing but failed as a result of these changes was updated to continue passing and a duplicate test'2' added in the subclass and marked as failing. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/dcd8c471ef903c1f89a95ccac27b169b39f0fcb7

Patch Set 1 #

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -13 lines)			Patch
	M	pkg/analyzer/test/generated/parser_fasta_test.dart	View		6 chunks	+66 lines, -6 lines	0 comments	Download
	M	pkg/analyzer/test/generated/parser_test.dart	View		7 chunks	+42 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

danrubel

3 years, 4 months ago (2017-07-31 03:12:51 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
dcd8c471ef903c1f89a95ccac27b169b39f0fcb7 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages