Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2989993002: fix unsound cast failures in tests (Closed)

Created:
3 years, 4 months ago by Jennifer Messerly
Modified:
3 years, 4 months ago
Reviewers:
vsm, Bob Nystrom
CC:
reviews_dartlang.org, Bob Nystrom
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix unsound cast failures in tests the "whitelist" option to ignore cast failures is no longer used by most tests (I'm investigating what to do about package:unittest) R=rnystrom@google.com, vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/bba4b68d51594298aea2137937678a7e491069f9

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -122 lines) Patch
M pkg/dev_compiler/test/browser/language_tests.js View 1 11 chunks +2 lines, -31 lines 0 comments Download
M tests/corelib_2/sort_helper.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M tests/corelib_strong/iterable_empty_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib_strong/iterable_join_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/corelib_strong/list_insert_all_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/corelib_strong/sort_helper.dart View 7 chunks +12 lines, -9 lines 0 comments Download
M tests/language_strong/async_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language_strong/many_named_arguments_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib_strong/collection/linked_list_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib_strong/convert/chunked_conversion_utf82_test.dart View 3 chunks +11 lines, -11 lines 0 comments Download
M tests/lib_strong/convert/chunked_conversion_utf83_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/lib_strong/convert/chunked_conversion_utf86_test.dart View 1 chunk +9 lines, -9 lines 0 comments Download
M tests/lib_strong/convert/chunked_conversion_utf87_test.dart View 1 chunk +9 lines, -9 lines 0 comments Download
M tests/lib_strong/convert/streamed_conversion_json_decode1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib_strong/convert/unicode_tests.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/lib_strong/convert/utf82_test.dart View 1 chunk +9 lines, -9 lines 0 comments Download
M tests/lib_strong/typed_data/typed_list_iterable_test.dart View 4 chunks +25 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Jennifer Messerly
3 years, 4 months ago (2017-07-29 02:50:35 UTC) #3
vsm
lgtm
3 years, 4 months ago (2017-07-31 20:59:35 UTC) #4
Bob Nystrom
LGTM++! So satisfying seeing these get cleaner and sounder.
3 years, 4 months ago (2017-07-31 21:14:04 UTC) #6
Jennifer Messerly
3 years, 4 months ago (2017-07-31 21:30:48 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
bba4b68d51594298aea2137937678a7e491069f9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698