Issue 298993005: Cast Channel API test for open error case.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 298993005: Cast Channel API test for open error case. (Closed)

Created:
6 years, 7 months ago by Munjal (Google)

Modified:
6 years, 7 months ago

Reviewers:
mark a. foltz, Wez

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Cast Channel API test for open error case. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273084

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -15 lines)			Patch
M	chrome/browser/extensions/api/cast_channel/cast_channel_apitest.cc	View	5 chunks	+39 lines, -1 line	0 comments	Download
A	chrome/test/data/extensions/api_test/cast_channel/api/test_open_error.html	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/cast_channel/api/test_open_error.js	View	1 chunk	+7 lines, -14 lines	0 comments	Download

Total messages: 6 (0 generated)

Munjal (Google)

This is the same patch as https://codereview.chromium.org/165293002/ The other one is out of date and ...

6 years, 7 months ago (2014-05-22 19:03:22 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/munjal@chromium.org/298993005/1

6 years, 7 months ago (2014-05-27 18:27:10 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...

6 years, 7 months ago (2014-05-27 21:57:47 UTC) #5

Message was sent while issue was closed.

Change committed as 273084