Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 298993003: Show ServiceWorkers in chrome://inspect. (Closed)

Created:
6 years, 7 months ago by horo
Modified:
6 years, 7 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, arv+watch_chromium.org, horo+watch_chromium.org, kinuko+watch, alecflett+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Show ServiceWorkers in chrome://inspect. To show the information about ServiceWorkers I added iframe of "chrome://serviceworker-internals/#iframe" to chrome://inspect. And I used postMessage() to achieve the cross-domain messaging between chrome://inspect and chrome://serviceworker-internals. BUG=358657 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272715

Patch Set 1 : #

Total comments: 4

Patch Set 2 : fix alignment #

Total comments: 2

Patch Set 3 : Remove service-workers-list when no worker. #

Total comments: 4

Patch Set 4 : incorporated kinuko's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -3 lines) Patch
M chrome/browser/resources/inspect/inspect.css View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/inspect/inspect.html View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/inspect/inspect.js View 1 2 4 chunks +60 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui.h View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui.cc View 1 1 chunk +25 lines, -0 lines 0 comments Download
M content/browser/resources/service_worker/serviceworker_internals.js View 1 2 3 4 chunks +44 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_internals_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/url_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/url_constants.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
horo
yurys@ Could you please review this? Thank you.
6 years, 7 months ago (2014-05-22 15:24:22 UTC) #1
yurys
Overall looks good. Vlad, could you please review inspect_ui changes? https://codereview.chromium.org/298993003/diff/20001/content/browser/resources/service_worker/serviceworker_internals.js File content/browser/resources/service_worker/serviceworker_internals.js (right): https://codereview.chromium.org/298993003/diff/20001/content/browser/resources/service_worker/serviceworker_internals.js#newcode18 ...
6 years, 7 months ago (2014-05-23 09:22:40 UTC) #2
horo
https://codereview.chromium.org/298993003/diff/20001/content/browser/resources/service_worker/serviceworker_internals.js File content/browser/resources/service_worker/serviceworker_internals.js (right): https://codereview.chromium.org/298993003/diff/20001/content/browser/resources/service_worker/serviceworker_internals.js#newcode18 content/browser/resources/service_worker/serviceworker_internals.js:18: return; On 2014/05/23 09:22:41, yurys wrote: > style: wrong ...
6 years, 7 months ago (2014-05-23 10:49:02 UTC) #3
Vladislav Kaznacheev
https://codereview.chromium.org/298993003/diff/40001/chrome/browser/resources/inspect/inspect.js File chrome/browser/resources/inspect/inspect.js (right): https://codereview.chromium.org/298993003/diff/40001/chrome/browser/resources/inspect/inspect.js#newcode108 chrome/browser/resources/inspect/inspect.js:108: var list = $('service-workers-list-' + partition_id); Do partitions ever ...
6 years, 7 months ago (2014-05-23 11:03:28 UTC) #4
horo
https://codereview.chromium.org/298993003/diff/40001/chrome/browser/resources/inspect/inspect.js File chrome/browser/resources/inspect/inspect.js (right): https://codereview.chromium.org/298993003/diff/40001/chrome/browser/resources/inspect/inspect.js#newcode108 chrome/browser/resources/inspect/inspect.js:108: var list = $('service-workers-list-' + partition_id); On 2014/05/23 11:03:28, ...
6 years, 7 months ago (2014-05-23 11:21:33 UTC) #5
Vladislav Kaznacheev
lgtm
6 years, 7 months ago (2014-05-23 13:53:29 UTC) #6
horo
kinuko@ Could you please review serviceworker_internals.js and service_worker_internals_ui.cc?
6 years, 7 months ago (2014-05-23 13:59:53 UTC) #7
horo
jochen@ Could you please review url_constants.*?
6 years, 7 months ago (2014-05-23 14:01:00 UTC) #8
jochen (gone - plz use gerrit)
content/public lgtm
6 years, 7 months ago (2014-05-23 14:04:23 UTC) #9
kinuko
https://codereview.chromium.org/298993003/diff/60001/content/browser/resources/service_worker/serviceworker_internals.js File content/browser/resources/service_worker/serviceworker_internals.js (right): https://codereview.chromium.org/298993003/diff/60001/content/browser/resources/service_worker/serviceworker_internals.js#newcode73 content/browser/resources/service_worker/serviceworker_internals.js:73: registration.active.running_status != 'RUNNING') { How are we going to ...
6 years, 7 months ago (2014-05-23 14:19:33 UTC) #10
horo
https://codereview.chromium.org/298993003/diff/60001/content/browser/resources/service_worker/serviceworker_internals.js File content/browser/resources/service_worker/serviceworker_internals.js (right): https://codereview.chromium.org/298993003/diff/60001/content/browser/resources/service_worker/serviceworker_internals.js#newcode73 content/browser/resources/service_worker/serviceworker_internals.js:73: registration.active.running_status != 'RUNNING') { On 2014/05/23 14:19:33, kinuko wrote: ...
6 years, 7 months ago (2014-05-23 14:37:09 UTC) #11
kinuko
lgtm
6 years, 7 months ago (2014-05-23 14:55:41 UTC) #12
horo
The CQ bit was checked by horo@chromium.org
6 years, 7 months ago (2014-05-23 15:27:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/298993003/80001
6 years, 7 months ago (2014-05-23 15:28:17 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 18:55:22 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 21:04:24 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/32168)
6 years, 7 months ago (2014-05-23 21:04:24 UTC) #17
horo
The CQ bit was checked by horo@chromium.org
6 years, 7 months ago (2014-05-24 00:03:28 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/298993003/80001
6 years, 7 months ago (2014-05-24 00:05:07 UTC) #19
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 12:28:03 UTC) #20
Message was sent while issue was closed.
Change committed as 272715

Powered by Google App Engine
This is Rietveld 408576698