Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2989883002: Add sourceFactory getter to AnalysisSession (Closed)

Created:
3 years, 4 months ago by Brian Wilkerson
Modified:
3 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, mfairhurst
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M pkg/analysis_server/lib/src/computer/import_elements_computer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/dart/analysis/session.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/session.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/session_test.dart View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 4 months ago (2017-07-27 21:50:53 UTC) #2
scheglov
LGTM
3 years, 4 months ago (2017-07-27 21:54:08 UTC) #3
Brian Wilkerson
3 years, 4 months ago (2017-07-28 13:18:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
de0b7a2f4015005b2cb7bf78e01703e0666d93e0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698