Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2989863002: Migrated test block 19 to Dart 2.0. (Closed)

Created:
3 years, 4 months ago by bkonyi
Modified:
3 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrated test block 19 to Dart 2.0. Added 'toString()' to lines 63 and 99 of regexp/global_test. BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/4d6f6a8bbdcde740470aa24e0b772f78202eb03b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1904 lines) Patch
M tests/corelib/corelib.status View 3 chunks +0 lines, -15 lines 0 comments Download
D tests/corelib/regexp/char-insensitive_test.dart View 1 chunk +0 lines, -68 lines 0 comments Download
D tests/corelib/regexp/character-match-out-of-order_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D tests/corelib/regexp/compile-crash_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D tests/corelib/regexp/compile_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D tests/corelib/regexp/constructor_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D tests/corelib/regexp/default_arguments_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/corelib/regexp/dotstar_test.dart View 1 chunk +0 lines, -166 lines 0 comments Download
D tests/corelib/regexp/early-acid3-86_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D tests/corelib/regexp/ecma-regex-examples_test.dart View 1 chunk +0 lines, -71 lines 0 comments Download
D tests/corelib/regexp/extended-characters-match_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D tests/corelib/regexp/extended-characters-more_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D tests/corelib/regexp/find-first-asserted_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D tests/corelib/regexp/global_test.dart View 1 chunk +0 lines, -184 lines 0 comments Download
D tests/corelib/regexp/indexof_test.dart View 1 chunk +0 lines, -105 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 4 chunks +28 lines, -0 lines 0 comments Download
A + tests/corelib_2/regexp/char-insensitive_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/character-match-out-of-order_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/compile-crash_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/compile_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/constructor_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/default_arguments_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/dotstar_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/early-acid3-86_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/ecma-regex-examples_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/extended-characters-match_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/extended-characters-more_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/find-first-asserted_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/global_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + tests/corelib_2/regexp/indexof_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/corelib_strong/corelib_strong.status View 2 chunks +0 lines, -10 lines 0 comments Download
D tests/corelib_strong/regexp/char-insensitive_test.dart View 1 chunk +0 lines, -68 lines 0 comments Download
D tests/corelib_strong/regexp/character-match-out-of-order_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D tests/corelib_strong/regexp/compile-crash_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D tests/corelib_strong/regexp/compile_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D tests/corelib_strong/regexp/constructor_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D tests/corelib_strong/regexp/default_arguments_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/corelib_strong/regexp/dotstar_test.dart View 1 chunk +0 lines, -166 lines 0 comments Download
D tests/corelib_strong/regexp/early-acid3-86_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D tests/corelib_strong/regexp/ecma-regex-examples_test.dart View 1 chunk +0 lines, -71 lines 0 comments Download
D tests/corelib_strong/regexp/extended-characters-match_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D tests/corelib_strong/regexp/extended-characters-more_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D tests/corelib_strong/regexp/find-first-asserted_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D tests/corelib_strong/regexp/global_test.dart View 1 chunk +0 lines, -184 lines 0 comments Download
D tests/corelib_strong/regexp/indexof_test.dart View 1 chunk +0 lines, -105 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bkonyi
3 years, 4 months ago (2017-07-28 19:55:03 UTC) #2
Bob Nystrom
lgtm
3 years, 4 months ago (2017-07-31 20:50:47 UTC) #3
bkonyi
3 years, 4 months ago (2017-08-01 19:24:30 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
4d6f6a8bbdcde740470aa24e0b772f78202eb03b.

Powered by Google App Engine
This is Rietveld 408576698