Issue 2989783002: Improve DEPS compatibility with planned gclient changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2989783002: Improve DEPS compatibility with planned gclient changes (Closed)

Created:
3 years, 4 months ago by Paweł Hajdan Jr.

Modified:
3 years, 4 months ago

Reviewers:
zra, Bill Hesse

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Improve DEPS compatibility with planned gclient changes BUG=570091, 748486 R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/c8b39cee64e10f4efa8f45d9e33b9bb34579c427

Patch Set 1 #

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -71 lines)			Patch
	M	DEPS	View		6 chunks	+66 lines, -71 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bill Hesse

Committed patchset #1 (id:1) manually as c8b39cee64e10f4efa8f45d9e33b9bb34579c427 (presubmit successful).

3 years, 4 months ago (2017-07-27 11:07:28 UTC) #4

zra

3 years, 4 months ago (2017-07-27 19:41:57 UTC) #5

Message was sent while issue was closed.

On 2017/07/27 11:07:28, Bill Hesse wrote:
> Committed patchset #1 (id:1) manually as
> c8b39cee64e10f4efa8f45d9e33b9bb34579c427 (presubmit successful).

Pawel, I specifically asked you to get an lgtm from me for changes to the DEPS
file. Please don't land changes like this to the DEPS file without my lgtm,
again.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages