Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: packages/charted/lib/charts/cartesian_renderers/stackedbar_chart_renderer.dart

Issue 2989763002: Update charted to 0.4.8 and roll (Closed)
Patch Set: Removed Cutch from list of reviewers Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: packages/charted/lib/charts/cartesian_renderers/stackedbar_chart_renderer.dart
diff --git a/packages/charted/lib/charts/cartesian_renderers/stackedbar_chart_renderer.dart b/packages/charted/lib/charts/cartesian_renderers/stackedbar_chart_renderer.dart
index 0d266759eccb8734d1ce3605b096243a26cc0771..d2adb792beaf340f0b077f4d76271eb8e65ee383 100644
--- a/packages/charted/lib/charts/cartesian_renderers/stackedbar_chart_renderer.dart
+++ b/packages/charted/lib/charts/cartesian_renderers/stackedbar_chart_renderer.dart
@@ -169,8 +169,9 @@ class StackedBarChartRenderer extends CartesianRendererBase {
var buildPath = (d, int i, Element e, bool animate, int roundIdx) {
var position = animate ? getInitialBarPos(i) : getBarPos(d, i),
length = animate ? 0 : getBarLength(d, i),
- radius =
- series.measures.elementAt(_reverseIdx(i)) == roundIdx ? RADIUS : 0,
+ radius = series.measures.elementAt(_reverseIdx(i)) == roundIdx
+ ? RADIUS
+ : 0,
path = (length != 0)
? verticalBars
? topRoundedRect(0, position, barWidth, length, radius)
@@ -261,14 +262,13 @@ class StackedBarChartRenderer extends CartesianRendererBase {
@override
Extent get extent {
assert(area != null && series != null);
- var rows = area.data.rows,
- max = SMALL_INT_MIN,
- min = SMALL_INT_MAX,
- rowIndex = 0;
+ var rows = area.data.rows, rowIndex = 0;
+ num max = SMALL_INT_MIN;
+ num min = SMALL_INT_MAX;
_lastMeasureWithData = new List.generate(rows.length, (i) => -1);
rows.forEach((row) {
- var bar = null;
+ num bar = null;
series.measures.forEach((idx) {
var value = row.elementAt(idx);
if (value != null && value.isFinite) {

Powered by Google App Engine
This is Rietveld 408576698