Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: packages/usage/test/web_test.dart

Issue 2989763002: Update charted to 0.4.8 and roll (Closed)
Patch Set: Removed Cutch from list of reviewers Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « packages/usage/test/uuid_test.dart ('k') | packages/usage/tool/drone.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packages/usage/test/web_test.dart
diff --git a/packages/usage/test/web_test.dart b/packages/usage/test/web_test.dart
index 5a9cd9815daebae05012c80da5f347f365f106e8..8d91ae9980ec1be13e2af5fe051d597970482555 100644
--- a/packages/usage/test/web_test.dart
+++ b/packages/usage/test/web_test.dart
@@ -6,6 +6,7 @@
library usage.web_test;
import 'dart:async';
+import 'dart:html';
import 'package:test/test.dart';
import 'package:usage/src/usage_impl_html.dart';
@@ -22,32 +23,34 @@ void main() {
usage_impl_test.defineTests();
uuid_test.defineTests();
- // Define some web specfic tests.
+ // Define some web specific tests.
defineWebTests();
}
void defineWebTests() {
group('HtmlPostHandler', () {
- test('sendPost', () {
+ test('sendPost', () async {
MockRequestor client = new MockRequestor();
- HtmlPostHandler postHandler = new HtmlPostHandler(
- mockRequestor: client.request);
- Map args = {'utv': 'varName', 'utt': 123};
- return postHandler.sendPost('http://www.google.com', args).then((_) {
- expect(client.sendCount, 1);
- });
+ HtmlPostHandler postHandler =
+ new HtmlPostHandler(mockRequestor: client.request);
+ Map<String, dynamic> args = {'utv': 'varName', 'utt': 123};
+
+ await postHandler.sendPost('http://www.google.com', args);
+ expect(client.sendCount, 1);
});
});
group('HtmlPersistentProperties', () {
test('add', () {
- HtmlPersistentProperties props = new HtmlPersistentProperties('foo_props');
+ HtmlPersistentProperties props =
+ new HtmlPersistentProperties('foo_props');
props['foo'] = 'bar';
expect(props['foo'], 'bar');
});
test('remove', () {
- HtmlPersistentProperties props = new HtmlPersistentProperties('foo_props');
+ HtmlPersistentProperties props =
+ new HtmlPersistentProperties('foo_props');
props['foo'] = 'bar';
expect(props['foo'], 'bar');
props['foo'] = null;
@@ -59,7 +62,7 @@ void defineWebTests() {
class MockRequestor {
int sendCount = 0;
- Future request(String url, {String method, String sendData}) {
+ Future<HttpRequest> request(String url, {String method, sendData}) {
expect(url, isNotEmpty);
expect(method, isNotEmpty);
expect(sendData, isNotEmpty);
« no previous file with comments | « packages/usage/test/uuid_test.dart ('k') | packages/usage/tool/drone.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698