Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: packages/usage/test/usage_test.dart

Issue 2989763002: Update charted to 0.4.8 and roll (Closed)
Patch Set: Removed Cutch from list of reviewers Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « packages/usage/test/usage_impl_test.dart ('k') | packages/usage/test/uuid_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packages/usage/test/usage_test.dart
diff --git a/packages/usage/test/usage_test.dart b/packages/usage/test/usage_test.dart
index bdbd6f1e39fba2c860a5e7d743869761ef3b2be8..37500a92d2272665154d0d1f0e9f709309f9e70d 100644
--- a/packages/usage/test/usage_test.dart
+++ b/packages/usage/test/usage_test.dart
@@ -14,7 +14,10 @@ void defineTests() {
test('simple', () {
AnalyticsMock mock = new AnalyticsMock();
mock.sendScreenView('main');
+ mock.sendScreenView('withParameters', parameters: {'cd1': 'custom'});
mock.sendEvent('files', 'save');
+ mock.sendEvent('eventWithParameters', 'save',
+ parameters: {'cd1': 'custom'});
mock.sendSocial('g+', 'plus', 'userid');
mock.sendTiming('compile', 123);
mock.startTimer('compile').finish();
@@ -26,38 +29,38 @@ void defineTests() {
group('sanitizeStacktrace', () {
test('replace file', () {
- expect(sanitizeStacktrace(
- '(file:///Users/foo/tmp/error.dart:3:13)',
- shorten: false),
+ expect(
+ sanitizeStacktrace('(file:///Users/foo/tmp/error.dart:3:13)',
+ shorten: false),
'(error.dart:3:13)');
});
test('replace files', () {
- expect(sanitizeStacktrace(
- 'foo (file:///Users/foo/tmp/error.dart:3:13)\n'
- 'bar (file:///Users/foo/tmp/error.dart:3:13)',
- shorten: false),
+ expect(
+ sanitizeStacktrace(
+ 'foo (file:///Users/foo/tmp/error.dart:3:13)\n'
+ 'bar (file:///Users/foo/tmp/error.dart:3:13)',
+ shorten: false),
'foo (error.dart:3:13)\nbar (error.dart:3:13)');
});
test('shorten 1', () {
- expect(sanitizeStacktrace(
- '(file:///Users/foo/tmp/error.dart:3:13)'),
+ expect(sanitizeStacktrace('(file:///Users/foo/tmp/error.dart:3:13)'),
'(error.dart:3:13)');
});
test('shorten 2', () {
- expect(sanitizeStacktrace(
- 'foo (file:///Users/foo/tmp/error.dart:3:13)\n'
- 'bar (file:///Users/foo/tmp/error.dart:3:13)'),
- 'foo (error.dart:3:13) bar (error.dart:3:13)');
+ expect(
+ sanitizeStacktrace('foo (file:///Users/foo/tmp/error.dart:3:13)\n'
+ 'bar (file:///Users/foo/tmp/error.dart:3:13)'),
+ 'foo (error.dart:3:13)\nbar (error.dart:3:13)');
});
test('shorten 3', () {
- expect(sanitizeStacktrace(
- 'foo (package:foo/foo.dart:3:13)\n'
- 'bar (dart:async/schedule_microtask.dart:41)'),
- 'foo (foo/foo.dart:3:13) bar (async/schedule_microtask.dart:41)');
+ expect(
+ sanitizeStacktrace('foo (package:foo/foo.dart:3:13)\n'
+ 'bar (dart:async/schedule_microtask.dart:41)'),
+ 'foo (package:foo/foo.dart:3:13)\nbar (dart:async/schedule_microtask.dart:41)');
});
});
}
« no previous file with comments | « packages/usage/test/usage_impl_test.dart ('k') | packages/usage/test/uuid_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698