packages/charted/lib/core/text_metrics.dart - Issue 2989763002: Update charted to 0.4.8 and roll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: packages/charted/lib/core/text_metrics.dart

Issue 2989763002: Update charted to 0.4.8 and roll (Closed)

Patch Set: Removed Cutch from list of reviewers Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: packages/charted/lib/core/text_metrics.dart

diff --git a/packages/charted/lib/core/text_metrics.dart b/packages/charted/lib/core/text_metrics.dart

index 9fb7d06d93eba4c4c4c818f5984f03f9af8cdede..a84f8289c690263cfbbfe7bc053308018c3f9c8e 100644

--- a/packages/charted/lib/core/text_metrics.dart

+++ b/packages/charted/lib/core/text_metrics.dart

@@ -100,6 +100,7 @@ class TextMetrics {

min = mid + 1;

}

+ if (max < 0) max = 0;

text = text.substring(0, indices[max]) + '…';

}

return text;