Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: packages/observable/lib/src/to_observable.dart

Issue 2989763002: Update charted to 0.4.8 and roll (Closed)
Patch Set: Removed Cutch from list of reviewers Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « packages/observable/lib/src/property_change_record.dart ('k') | packages/observable/pubspec.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packages/observable/lib/src/to_observable.dart
diff --git a/packages/observe/lib/src/to_observable.dart b/packages/observable/lib/src/to_observable.dart
similarity index 80%
rename from packages/observe/lib/src/to_observable.dart
rename to packages/observable/lib/src/to_observable.dart
index 931fb0404ebd5fbb3d46e1d93fffd82e143eb235..0a0f3168f89e8a7188b39bf2a95ea84acbabd0b1 100644
--- a/packages/observe/lib/src/to_observable.dart
+++ b/packages/observable/lib/src/to_observable.dart
@@ -1,10 +1,12 @@
-// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
+// Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-library observe.src.to_observable;
+library observable.src.to_observable;
-import 'package:observe/observe.dart';
+import 'observable.dart' show Observable;
+import 'observable_list.dart' show ObservableList;
+import 'observable_map.dart' show ObservableMap;
/// Converts the [Iterable] or [Map] to an [ObservableList] or [ObservableMap],
/// respectively. This is a convenience function to make it easier to convert
@@ -21,17 +23,17 @@ import 'package:observe/observe.dart';
/// If a conversion is peformed, mutations are only observed to the result of
/// this function. Changing the original collection will not affect it.
// TODO(jmesserly): ObservableSet?
-toObservable(value, {bool deep: true}) =>
+toObservable(dynamic value, {bool deep: true}) =>
deep ? _toObservableDeep(value) : _toObservableShallow(value);
-_toObservableShallow(value) {
+dynamic _toObservableShallow(dynamic value) {
if (value is Observable) return value;
if (value is Map) return new ObservableMap.from(value);
if (value is Iterable) return new ObservableList.from(value);
return value;
}
-_toObservableDeep(value) {
+dynamic _toObservableDeep(dynamic value) {
if (value is Observable) return value;
if (value is Map) {
var result = new ObservableMap.createFromType(value);
« no previous file with comments | « packages/observable/lib/src/property_change_record.dart ('k') | packages/observable/pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698