Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: packages/charted/lib/svg/axis.dart

Issue 2989763002: Update charted to 0.4.8 and roll (Closed)
Patch Set: Removed Cutch from list of reviewers Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « packages/charted/lib/locale/format/number_format.dart ('k') | packages/charted/pubspec.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packages/charted/lib/svg/axis.dart
diff --git a/packages/charted/lib/svg/axis.dart b/packages/charted/lib/svg/axis.dart
index 474b4365ba273afe5efeb49ac3155905af297441..fdc7d6083ea2d8efa846ed6bd155ea8c31c0a8ba 100644
--- a/packages/charted/lib/svg/axis.dart
+++ b/packages/charted/lib/svg/axis.dart
@@ -99,7 +99,6 @@ class SvgAxis {
var enter = ticks.enter.appendWithCallback((d, i, e) {
var group = Namespace.createChildElement('g', e)
- ..attributes['class'] = 'tick'
..append(Namespace.createChildElement('line', e))
..append(Namespace.createChildElement('text', e)
..attributes['dy'] =
@@ -113,6 +112,7 @@ class SvgAxis {
// All attributes/styles/classes that may change due to theme and scale.
// TODO(prsd): Order elements before updating ticks.
ticks.each((d, i, e) {
+ e.attributes['class'] = 'tick tick-$i';
Element line = e.firstChild;
Element text = e.lastChild;
bool isRTLText = false; // FIXME(prsd)
« no previous file with comments | « packages/charted/lib/locale/format/number_format.dart ('k') | packages/charted/pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698