packages/charted/lib/charts/data_transformers/aggregation_item.dart - Issue 2989763002: Update charted to 0.4.8 and roll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: packages/charted/lib/charts/data_transformers/aggregation_item.dart

Issue 2989763002: Update charted to 0.4.8 and roll (Closed)

Patch Set: Removed Cutch from list of reviewers Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « packages/charted/lib/charts/charts.dart ('k') | packages/charted/lib/charts/data_transformers/aggregation_transformer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: packages/charted/lib/charts/data_transformers/aggregation_item.dart

diff --git a/packages/charted/lib/charts/data_transformers/aggregation_item.dart b/packages/charted/lib/charts/data_transformers/aggregation_item.dart

index 5ac5b56e464a0b5ad696e761b25c10a718515e85..73f78a75ab6f7a3568f2025f1952dad4e089fd45 100644

--- a/packages/charted/lib/charts/data_transformers/aggregation_item.dart

+++ b/packages/charted/lib/charts/data_transformers/aggregation_item.dart

@@ -11,7 +11,7 @@ part of charted.charts;

/// AggregationItem is created by [AggregationModel] to make access to facts

/// observable. Users must use AggregationItem.isValid before trying to access

/// the aggregations.

-abstract class AggregationItem extends ChangeNotifier {

+abstract class AggregationItem extends Observable {

/// List of dimension fields in effect

List<String> dimensions;

@@ -42,7 +42,7 @@ abstract class AggregationItem extends ChangeNotifier {

/// Implementation of AggregationItem

/// Instances of _AggregationItemImpl are created only by AggregationModel

-class _AggregationItemImpl extends ChangeNotifier implements AggregationItem {

+class _AggregationItemImpl extends Observable implements AggregationItem {

static final List<String> derivedAggregationTypes = ['count', 'avg'];

AggregationModel model;