Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: packages/intl/lib/src/http_request_data_reader.dart

Issue 2989763002: Update charted to 0.4.8 and roll (Closed)
Patch Set: Removed Cutch from list of reviewers Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « packages/intl/lib/src/file_data_reader.dart ('k') | packages/intl/lib/src/icu_parser.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packages/intl/lib/src/http_request_data_reader.dart
diff --git a/packages/intl/lib/src/http_request_data_reader.dart b/packages/intl/lib/src/http_request_data_reader.dart
index cbe214dffd3039225d6b68ad647a99e5ee28b44d..2a24aa2e027c3ca6003ad3551963ce235e5d8c4a 100644
--- a/packages/intl/lib/src/http_request_data_reader.dart
+++ b/packages/intl/lib/src/http_request_data_reader.dart
@@ -2,10 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-/**
- * This contains a reader that accesses data using the HttpRequest
- * facility, and thus works only in the web browser.
- */
+/// This contains a reader that accesses data using the HttpRequest
+/// facility, and thus works only in the web browser.
library http_request_data_reader;
@@ -15,17 +13,14 @@ import 'intl_helpers.dart';
class HttpRequestDataReader implements LocaleDataReader {
- /** The base url from which we read the data. */
+ /// The base url from which we read the data.
String url;
HttpRequestDataReader(this.url);
Future read(String locale) {
- // TODO(alanknight): Remove this once it's not necessary for Chrome.
- // Without it, the tests will be flaky on Chrome. Issue 11834.
- var someNumber = new DateTime.now().millisecondsSinceEpoch;
var request = new HttpRequest();
request.timeout = 5000;
- return _getString('$url$locale.json?cacheBlocker=$someNumber', request)
+ return _getString('$url$locale.json', request)
.then((r) => r.responseText);
}
« no previous file with comments | « packages/intl/lib/src/file_data_reader.dart ('k') | packages/intl/lib/src/icu_parser.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698