Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1286)

Unified Diff: packages/unittest/test/test_common.dart

Issue 2989763002: Update charted to 0.4.8 and roll (Closed)
Patch Set: Removed Cutch from list of reviewers Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « packages/unittest/test/pretty_print_test.dart ('k') | packages/unittest/test/test_utils.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packages/unittest/test/test_common.dart
diff --git a/packages/unittest/test/test_common.dart b/packages/unittest/test/test_common.dart
index 7d7d70bbdee6d75628480a77fe29b5ae657e381a..4f9cd7ca7303fa7f6d6ab28d6f2834cda4960839 100644
--- a/packages/unittest/test/test_common.dart
+++ b/packages/unittest/test/test_common.dart
@@ -22,7 +22,7 @@ class SimpleIterable extends IterableBase<int> {
SimpleIterable(this.count);
- bool contains(int val) => count < val ? false : true;
+ bool contains(Object val) => val is int && val <= count;
bool any(bool f(element)) {
for (var i = 0; i <= count; i++) {
@@ -33,7 +33,7 @@ class SimpleIterable extends IterableBase<int> {
String toString() => "<[$count]>";
- Iterator get iterator {
+ Iterator<int> get iterator {
return new _SimpleIterator(count);
}
}
« no previous file with comments | « packages/unittest/test/pretty_print_test.dart ('k') | packages/unittest/test/test_utils.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698