Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Unified Diff: packages/quiver/CONTRIBUTING.md

Issue 2989763002: Update charted to 0.4.8 and roll (Closed)
Patch Set: Removed Cutch from list of reviewers Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « packages/quiver/CHANGELOG.md ('k') | packages/quiver/README.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packages/quiver/CONTRIBUTING.md
diff --git a/packages/quiver/CONTRIBUTING.md b/packages/quiver/CONTRIBUTING.md
index d320e5b26cd9020a60c6befc46997ea80051c1cd..75c2f33897ee7360dc04bcbfc96db3e85fccd301 100644
--- a/packages/quiver/CONTRIBUTING.md
+++ b/packages/quiver/CONTRIBUTING.md
@@ -19,7 +19,7 @@ the process as smooth as possible, we request the following:
(see above) before sending your pull request. It's quick, we promise!
* Have test cases for your changes and ensure that the existing ones pass in
checked mode.
- * Run your changes through `dartformat`. Follow the installation instructions
+ * Run your changes through `dartfmt`. Follow the installation instructions
in the [dart_style](https://github.com/dart-lang/dart_style) README for
more info.
* Squash your commits into a single commit with a good description. You can
@@ -27,5 +27,7 @@ the process as smooth as possible, we request the following:
Atlassian's
[tutorial](https://www.atlassian.com/git/tutorials/rewriting-history).
* During code review, go ahead and pile up commits addressing review
- comments. Once you get an LGTM (looks good to me) on the review, we'll ask
- you to squash your commits one last time, then we'll be good to merge!
+ comments. Once you get an LGTM (looks good to me) on the review, we'll
+ squash your commits and merge!
+ * If you're not already listed as an author in `pubspec.yaml`, remember to
+ add yourself and claim your rightful place amongst the Quiverati.
« no previous file with comments | « packages/quiver/CHANGELOG.md ('k') | packages/quiver/README.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698