Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: packages/code_transformers/lib/assets.dart

Issue 2989763002: Update charted to 0.4.8 and roll (Closed)
Patch Set: Removed Cutch from list of reviewers Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « packages/code_transformers/CHANGELOG.md ('k') | packages/code_transformers/lib/messages/build_logger.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packages/code_transformers/lib/assets.dart
diff --git a/packages/code_transformers/lib/assets.dart b/packages/code_transformers/lib/assets.dart
index 4a3516f63be475bf4314fc8ea7fa79228c131f5a..dacc582c186d50de09716719a6bd5be0f070a465 100644
--- a/packages/code_transformers/lib/assets.dart
+++ b/packages/code_transformers/lib/assets.dart
@@ -83,7 +83,7 @@ AssetId uriToAssetId(
return _extractOtherPackageId(1, segments, logger, span);
} else {
var prefix = segments[index];
- var fixedSegments = [];
+ var fixedSegments = <String>[];
fixedSegments.addAll(sourceSegments.map((_) => '..'));
fixedSegments.addAll(segments.sublist(index));
var fixedUrl = urlBuilder.joinAll(fixedSegments);
@@ -99,7 +99,7 @@ AssetId uriToAssetId(
}
AssetId _extractOtherPackageId(
- int index, List segments, TransformLogger logger, SourceSpan span) {
+ int index, List<String> segments, TransformLogger logger, SourceSpan span) {
if (index >= segments.length) return null;
var prefix = segments[index];
if (prefix != 'packages' && prefix != 'assets') return null;
@@ -140,7 +140,8 @@ String assetIdToUri(AssetId assetId,
return null;
}
return new Uri(
- path: path.url.relative(assetId.path, from: path.url.dirname(from.path)))
+ path: path.url
+ .relative(assetId.path, from: path.url.dirname(from.path)))
.toString();
}
« no previous file with comments | « packages/code_transformers/CHANGELOG.md ('k') | packages/code_transformers/lib/messages/build_logger.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698