Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: packages/csslib/lib/src/analyzer.dart

Issue 2989763002: Update charted to 0.4.8 and roll (Closed)
Patch Set: Removed Cutch from list of reviewers Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « packages/csslib/lib/parser.dart ('k') | packages/csslib/lib/src/css_printer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packages/csslib/lib/src/analyzer.dart
diff --git a/packages/csslib/lib/src/analyzer.dart b/packages/csslib/lib/src/analyzer.dart
index fc27ceb09834cb954ecc9878513de4f7ab708a01..7c7372cf2d2e6371e71688a06fd00d5fc431e260 100644
--- a/packages/csslib/lib/src/analyzer.dart
+++ b/packages/csslib/lib/src/analyzer.dart
@@ -243,7 +243,7 @@ class ExpandNestedSelectors extends Visitor {
var selectors = node.selectorGroup.selectors;
// Create a merged set of previous parent selectors and current selectors.
- var newSelectors = [];
+ var newSelectors = <Selector>[];
for (Selector selector in selectors) {
for (Selector nestedSelector in nestedSelectors) {
var seq = _mergeNestedSelector(nestedSelector.simpleSelectorSequences,
@@ -262,12 +262,11 @@ class ExpandNestedSelectors extends Visitor {
List<SimpleSelectorSequence> _mergeNestedSelector(
List<SimpleSelectorSequence> parent,
List<SimpleSelectorSequence> current) {
-
// If any & operator then the parent selector will be substituted otherwise
// the parent selector is pre-pended to the current selector.
var hasThis = current.any((s) => s.simpleSelector.isThis);
- var newSequence = [];
+ var newSequence = <SimpleSelectorSequence>[];
if (!hasThis) {
// If no & in the sector group then prefix with the parent selector.
@@ -302,7 +301,7 @@ class ExpandNestedSelectors extends Visitor {
List<SimpleSelectorSequence> sequences) {
if (sequences.isEmpty) return sequences;
- var newSequences = [];
+ var newSequences = <SimpleSelectorSequence>[];
var first = sequences.first;
newSequences.add(new SimpleSelectorSequence(
first.simpleSelector, first.span, TokenKind.COMBINATOR_DESCENDANT));
@@ -592,7 +591,7 @@ class CallMixin extends Visitor {
* Given a mixin's defined arguments return a cloned mixin defintion that has
* replaced all defined arguments with user's supplied VarUsages.
*/
- MixinDefinition transform(List callArgs) {
+ MixinDefinition transform(List<List<Expression>> callArgs) {
// TODO(terry): Handle default arguments and varArgs.
// Transform mixin with callArgs.
for (var index = 0; index < _definedArgs.length; index++) {
@@ -628,11 +627,11 @@ class CallMixin extends Visitor {
}
/** Rip apart var def with multiple parameters. */
- List<List<TreeNode>> _varDefsAsCallArgs(var callArg) {
- var defArgs = [];
+ List<List<Expression>> _varDefsAsCallArgs(var callArg) {
+ var defArgs = <List<Expression>>[];
if (callArg is List && callArg[0] is VarUsage) {
var varDef = varDefs[callArg[0].name];
- var expressions = varDef.expression.expressions;
+ var expressions = (varDef.expression as Expressions).expressions;
assert(expressions.length > 1);
for (var expr in expressions) {
if (expr is! OperatorComma) {
@@ -746,8 +745,8 @@ class DeclarationIncludes extends Visitor {
if (!_allIncludes(mixinDef.rulesets) && currDeclGroup != null) {
var index = _findInclude(currDeclGroup.declarations, node);
if (index != -1) {
- currDeclGroup.declarations.replaceRange(
- index, index + 1, [new NoOp()]);
+ currDeclGroup.declarations
+ .replaceRange(index, index + 1, [new NoOp()]);
}
_messages.warning(
"Using top-level mixin ${node.include.name} as a declaration",
@@ -756,11 +755,11 @@ class DeclarationIncludes extends Visitor {
// We're a list of @include(s) inside of a mixin ruleset - convert
// to a list of IncludeMixinAtDeclaration(s).
var origRulesets = mixinDef.rulesets;
- var rulesets = [];
+ var rulesets = <Declaration>[];
if (origRulesets.every((ruleset) => ruleset is IncludeDirective)) {
origRulesets.forEach((ruleset) {
- rulesets
- .add(new IncludeMixinAtDeclaration(ruleset, ruleset.span));
+ rulesets.add(new IncludeMixinAtDeclaration(
+ ruleset as IncludeDirective, ruleset.span));
});
_IncludeReplacer.replace(_styleSheet, node, rulesets);
}
@@ -841,7 +840,7 @@ class DeclarationIncludes extends Visitor {
/** @include as a top-level with ruleset(s). */
class _IncludeReplacer extends Visitor {
final _include;
- final List<Declaration> _newDeclarations;
+ final List<TreeNode> _newDeclarations;
bool _foundAndReplaced = false;
/**
@@ -849,7 +848,7 @@ class _IncludeReplacer extends Visitor {
* with the [newRules].
*/
static void replace(
- StyleSheet ss, var include, List<Declaration> newDeclarations) {
+ StyleSheet ss, var include, List<TreeNode> newDeclarations) {
var visitor = new _IncludeReplacer(include, newDeclarations);
visitor.visitStyleSheet(ss);
}
« no previous file with comments | « packages/csslib/lib/parser.dart ('k') | packages/csslib/lib/src/css_printer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698