Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: packages/csslib/test/selector_test.dart

Issue 2989763002: Update charted to 0.4.8 and roll (Closed)
Patch Set: Removed Cutch from list of reviewers Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « packages/csslib/test/nested_test.dart ('k') | packages/csslib/test/testing.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packages/csslib/test/selector_test.dart
diff --git a/packages/csslib/test/selector_test.dart b/packages/csslib/test/selector_test.dart
index aefab164d0ed0f356aeddaaf5e3ca7e7f2e15dfa..66e208075630a8ca1b2b1ca9eb5659b6b0f9143a 100644
--- a/packages/csslib/test/selector_test.dart
+++ b/packages/csslib/test/selector_test.dart
@@ -5,12 +5,13 @@
library selector_test;
import 'package:csslib/parser.dart';
+import 'package:csslib/src/messages.dart';
import 'package:test/test.dart';
import 'testing.dart';
void testSelectorSuccesses() {
- var errors = [];
+ var errors = <Message>[];
var selectorAst = selector('#div .foo', errors: errors);
expect(errors.isEmpty, true, reason: errors.toString());
expect('#div .foo', compactOuptut(selectorAst));
@@ -45,17 +46,38 @@ void testSelectorSuccesses() {
selectorAst = selector('#_privateId', errors: errors..clear());
expect(errors.isEmpty, true, reason: errors.toString());
expect('#_privateId', compactOuptut(selectorAst));
+
+ selectorAst = selector(':host', errors: errors..clear());
+ expect(errors.isEmpty, true, reason: errors.toString());
+ expect(compactOuptut(selectorAst), ':host');
+
+ selectorAst = selector(':host(.foo)', errors: errors..clear());
+ expect(errors.isEmpty, true, reason: errors.toString());
+ expect(compactOuptut(selectorAst), ':host(.foo)');
+
+ selectorAst = selector(':host-context(.foo)', errors: errors..clear());
+ expect(errors.isEmpty, true, reason: errors.toString());
+ expect(compactOuptut(selectorAst), ':host-context(.foo)');
+
+ selectorAst = selector('.a /deep/ .b', errors: errors..clear());
+ expect(errors.isEmpty, true, reason: errors.toString());
+ expect(compactOuptut(selectorAst), '.a /deep/ .b');
+
+ selectorAst = selector('.x >>> .y', errors: errors..clear());
+ expect(errors.isEmpty, true, reason: errors.toString());
+ expect(compactOuptut(selectorAst), '.x >>> .y');
}
// TODO(terry): Move this failure case to a failure_test.dart when the analyzer
// and validator exit then they'll be a bunch more checks.
void testSelectorFailures() {
- var errors = [];
+ var errors = <Message>[];
// Test for invalid class name (can't start with number).
selector('.foobar .1a-story .xyzzy', errors: errors);
expect(errors.isEmpty, false);
- expect(errors[0].toString(),
+ expect(
+ errors[0].toString(),
'error on line 1, column 9: name must start with a alpha character, but '
'found a number\n'
'.foobar .1a-story .xyzzy\n'
« no previous file with comments | « packages/csslib/test/nested_test.dart ('k') | packages/csslib/test/testing.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698