packages/charted/lib/charts/data_transformers/filter_transformer.dart - Issue 2989763002: Update charted to 0.4.8 and roll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: packages/charted/lib/charts/data_transformers/filter_transformer.dart

Issue 2989763002: Update charted to 0.4.8 and roll (Closed)

Patch Set: Removed Cutch from list of reviewers Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « packages/charted/lib/charts/data_transformers/aggregation_transformer.dart ('k') | packages/charted/lib/charts/data_transformers/transpose_transformer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: packages/charted/lib/charts/data_transformers/filter_transformer.dart

diff --git a/packages/charted/lib/charts/data_transformers/filter_transformer.dart b/packages/charted/lib/charts/data_transformers/filter_transformer.dart

index cc002eae1b1285454b6c6a3eb6c817673e677967..55b5b335f299b43733f19d00a4825d57567b3d1f 100644

--- a/packages/charted/lib/charts/data_transformers/filter_transformer.dart

+++ b/packages/charted/lib/charts/data_transformers/filter_transformer.dart

@@ -14,7 +14,7 @@ typedef bool FilterFunction(dynamic value);

/// of data will be tested by passing the value at target column to the filter

/// function. If filter function returns false, the row will be filtered out.

/// This transformer does not modify the column part of the input ChartData.

-class FilterTransformer extends ChangeNotifier

+class FilterTransformer extends Observable

implements ChartDataTransform, ChartData {

final SubscriptionsDisposer _dataSubscriptions = new SubscriptionsDisposer();

List<ChartColumnSpec> columns;