Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: packages/smoke/lib/src/default_transformer.dart

Issue 2989763002: Update charted to 0.4.8 and roll (Closed)
Patch Set: Removed Cutch from list of reviewers Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « packages/smoke/lib/src/common.dart ('k') | packages/smoke/lib/src/implementation.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file.
4
5 /// Transformer that replaces the default mirror-based implementation of smoke,
6 /// so that during deploy smoke doesn't include any dependency on dart:mirrors.
7 library smoke.src.default_transformer;
8
9 import 'dart:async';
10 import 'package:barback/barback.dart';
11
12 /// Replaces the default mirror-based implementation of smoke in
13 /// `pacakge:smoke/implementation.dart`, so that during deploy smoke doesn't
14 /// include any dependency on dart:mirrors.
15 // TODO(sigmund): include tests that run this transformation automatically.
16 class DefaultTransformer extends Transformer {
17 DefaultTransformer.asPlugin();
18
19 /// Only apply to `lib/src/implementation.dart`.
20 // TODO(nweiz): This should just take an AssetId when barback <0.13.0 support
21 // is dropped.
22 Future<bool> isPrimary(idOrAsset) {
23 var id = idOrAsset is AssetId ? idOrAsset : idOrAsset.id;
24 return new Future.value(
25 id.package == 'smoke' && id.path == 'lib/src/implementation.dart');
26 }
27
28 Future apply(Transform transform) {
29 var id = transform.primaryInput.id;
30 return transform.primaryInput.readAsString().then((code) {
31 // Note: this rewrite is highly-coupled with how implementation.dart is
32 // written. Make sure both are updated in sync.
33 transform.addOutput(new Asset.fromString(id, code
34 .replaceAll(
35 new RegExp('new Reflective[^;]*;'), 'throwNotConfiguredError();')
36 .replaceAll("import 'package:smoke/mirrors.dart';", '')));
37 });
38 }
39 }
40
41 /** Transformer phases which should be applied to the smoke package. */
42 List<List<Transformer>> get phasesForSmoke =>
43 [[new DefaultTransformer.asPlugin()]];
OLDNEW
« no previous file with comments | « packages/smoke/lib/src/common.dart ('k') | packages/smoke/lib/src/implementation.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698