Update charted to 0.4.8 and roll

packages/code_transformers/lib/messages/messages.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Defines messages templates and an adapter for TransformLogger to be able
 /// report error messages from transformers and refer to them in a consistent
 /// manner long term.
 library code_transformers.messages;
 
 // Note: this library purposely doesn't depend on dart:io, dart:html, or barback
 // so it can easily be used both in the transformers and in client-side apps
 // (for example in the log_injector).
 import 'dart:collection' show LinkedHashMap;
+
 import 'package:source_span/source_span.dart';
 
 /// A globally unique identifier for an error message. This identifier should be
 /// stable, that is, it should never change after it is asigned to a particular
 /// message. That allows us to document our error messages and make them
 /// searchable for prosperity.
-class MessageId implements Comparable {
+class MessageId implements Comparable<MessageId> {
   /// Name of the package that declares this message.
   final String package;
 
   /// Message identifier number, unique within the package.
   final int id;
 
   const MessageId(this.package, this.id);
 
   static const MessageId NOT_SPECIFIED = const MessageId('unknown', 0);
 
@@ skipping 10 matching lines @@
   }
 
   /// Creates a new [MessageId] from an encoded value produced via [toJson].
   factory MessageId.fromJson(data) {
     var index = data.lastIndexOf('#');
     if (index == -1) throw 'Invalid message id: $data';
     return new MessageId(
         data.substring(0, index), int.parse(data.substring(index + 1)));
   }
 
-  operator ==(MessageId other) => package == other.package && id == other.id;
+  operator ==(Object other) =>
+      other is MessageId && package == other.package && id == other.id;
+
   int get hashCode => 31 * package.hashCode + id;
 }
 
 /// An instance of an error message. These are typically produced from a
 /// [MessageTemplate].
 class Message {
   /// A globally unique identifier for this message.
   final MessageId id;
 
   /// A snippet message that is presented to the user.
@@ skipping 95 matching lines @@
           line: locData['line'],
           column: locData['column']);
       span = new SourceSpan(start, end, spanData['text']);
     }
     return new BuildLogEntry(
         new Message.fromJson(data['message']), span, data['level']);
   }
 
   /// Serializes this log entry to JSON.
   Map toJson() {
-    var data = {'level': level, 'message': message.toJson(),};
+    var data = {
+      'level': level,
+      'message': message.toJson(),
+    };
     if (span != null) {
       data['span'] = {
         'start': {
           'url': span.start.sourceUrl.toString(),
           'offset': span.start.offset,
           'line': span.start.line,
           'column': span.start.column,
         },
         'end': {
           'url': span.end.sourceUrl.toString(),
           'offset': span.end.offset,
           'line': span.end.line,
           'column': span.end.column,
         },
         'text': span.text,
       };
     }
     return data;
   }
+
   String toString() => '${toJson()}';
 }
 
 /// A table of entries, that clusters error messages by id.
 class LogEntryTable {
   final Map<MessageId, List<BuildLogEntry>> entries;
 
   LogEntryTable() : entries = new LinkedHashMap();
 
   /// Creates a new [LogEntryTable] from an encoded value produced via [toJson].
-  factory LogEntryTable.fromJson(Map json) {
+  factory LogEntryTable.fromJson(Map<String, Iterable> json) {
     var res = new LogEntryTable();
     for (String key in json.keys) {
       var id = new MessageId.fromJson(key);
       res.entries[id] =
           json[key].map((v) => new BuildLogEntry.fromJson(v)).toList();
     }
     return res;
   }
 
   /// Serializes this entire table as JSON.
   Map toJson() {
     var res = {};
     entries.forEach((key, value) {
       res['$key'] = value.map((e) => e.toJson()).toList();
     });
     return res;
   }
+
   String toString() => '${toJson()}';
 
   void add(BuildLogEntry entry) {
     entries.putIfAbsent(entry.message.id, () => []).add(entry);
   }
+
   void addAll(LogEntryTable other) {
     for (var key in other.entries.keys) {
       var values = entries.putIfAbsent(key, () => []);
       values.addAll(other.entries[key]);
     }
   }
 }