Issue 2989743002: Add some more validation of things in expect that should not be used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2989743002: Add some more validation of things in expect that should not be used. (Closed)

Created:
3 years, 4 months ago by Bob Nystrom

Modified:
3 years, 4 months ago

Reviewers:
bkonyi

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Add some more validation of things in expect that should not be used. Also add some helper functions in expect. R=bkonyi@google.com Committed: https://github.com/dart-lang/sdk/commit/cc8ae6b7233416e80c57b8f723a46a5cd3bb6fca

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -2 lines)			Patch
	M	pkg/expect/lib/expect.dart	View		4 chunks	+32 lines, -2 lines	0 comments	Download
	M	tools/migration/lib/src/validate.dart	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

Bob Nystrom

3 years, 4 months ago (2017-07-26 23:52:23 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cc8ae6b7233416e80c57b8f723a46a5cd3bb6fca (presubmit successful).