[Mac] Draw the circular avatar programmatically rather than with a frame.

[Mac] Draw the circular avatar programmatically rather than with a frame.

Since we had to change it on Win/Linux, I thought it would be good to be 
consistent and draw the frame on Mac as well.

BUG=372721
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272719

[noms (inactive), 2014-05-23 14:20:36]

Here it is! The changePhotoButton_ is still a square button, but since a) the
background of the bubble isn't going to change (like it does on Linux), and b)
it's pretty transparent, so it's not visible, I don't think it's worth
subclassing it just to override drawRect and display it as a circle. Unless you
know of a better way :)

Please take a look. Thanks!

[groby-ooo-7-16, 2014-05-23 17:33:41]

Nope, looks perfect. (% nits :)

Do you want the button still behave as a square, or do you want it to behave as
a circle button? (If the latter, you need to override hitTest)

https://codereview.chromium.org/298973007/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (left):

https://codereview.chromium.org/298973007/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:419:
GetNativeImageNamed(IDR_ICON_PROFILES_AVATAR_PHOTO_FRAME).AsNSImage()];
Can you get rid of the image resource, too?

https://codereview.chromium.org/298973007/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right):

https://codereview.chromium.org/298973007/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:423: {
You can kill the scoped state - Cocoa automatically has a save/restore state
call around drawRect

[noms (inactive), 2014-05-23 19:32:13]

I think it's fine for the hit target to be a square too. I think the difference
is pretty minor, and I don't think users will notice this. Famous last words...

https://codereview.chromium.org/298973007/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (left):

https://codereview.chromium.org/298973007/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:419:
GetNativeImageNamed(IDR_ICON_PROFILES_AVATAR_PHOTO_FRAME).AsNSImage()];
Not yet -- until it lands, it's still being used on Win/Linux, and I think
Android was going to pick it up. I will double check with them (and if not,
delete it in a different CL)
On 2014/05/23 17:33:42, groby wrote:
> Can you get rid of the image resource, too?

https://codereview.chromium.org/298973007/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right):

https://codereview.chromium.org/298973007/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:423: {
Nice! Done.
 On 2014/05/23 17:33:42, groby wrote:
> You can kill the scoped state - Cocoa automatically has a save/restore state
> call around drawRect

[groby-ooo-7-16, 2014-05-23 19:34:06]

LGTM

[noms (inactive), 2014-05-23 19:35:37]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2014-05-23 19:36:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/noms@chromium.org/298973007/60001

[commit-bot: I haz the power, 2014-05-24 09:04:51]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-24 12:38:22]

Change committed as 272719