Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2989723002: Migrated test block 22 to Dart 2.0 (Closed)

Created:
3 years, 4 months ago by bkonyi
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrated test block 22 to Dart 2.0 No updates made to tests. BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/26c84797297ee4234e7d0d7f27a49e1aea9b77a0

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -16517 lines) Patch
M tests/corelib/corelib.status View 5 chunks +0 lines, -6 lines 0 comments Download
D tests/corelib/regexp/pcre-test-4_test.dart View 1 chunk +0 lines, -1031 lines 0 comments Download
D tests/corelib/regexp/pcre_test.dart View 1 chunk +0 lines, -7225 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 4 chunks +11 lines, -0 lines 2 comments Download
A + tests/corelib_2/regexp/pcre-test-4_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/pcre_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/corelib_strong/corelib_strong.status View 1 chunk +0 lines, -1 line 0 comments Download
D tests/corelib_strong/regexp/pcre-test-4_test.dart View 1 chunk +0 lines, -1031 lines 0 comments Download
D tests/corelib_strong/regexp/pcre_test.dart View 1 chunk +0 lines, -7225 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
bkonyi
3 years, 4 months ago (2017-07-26 16:59:11 UTC) #2
Bob Nystrom
lgtm
3 years, 4 months ago (2017-07-26 20:13:18 UTC) #3
bkonyi
Committed patchset #1 (id:1) manually as 26c84797297ee4234e7d0d7f27a49e1aea9b77a0.
3 years, 4 months ago (2017-07-28 18:28:14 UTC) #5
Vyacheslav Egorov (Google)
3 years, 4 months ago (2017-07-31 11:34:48 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/2989723002/diff/1/tests/corelib_2/corelib_2.s...
File tests/corelib_2/corelib_2.status (right):

https://codereview.chromium.org/2989723002/diff/1/tests/corelib_2/corelib_2.s...
tests/corelib_2/corelib_2.status:286: regexp/pcre_test: Crash
These two lines make no sense together. Is it Crash or is it RuntimeError?

https://codereview.chromium.org/2989723002/diff/1/tests/corelib_2/corelib_2.s...
tests/corelib_2/corelib_2.status:421: rexexp/pcre_test: Pass, Slow, Timeout
Typo in the name:

rexexp

Powered by Google App Engine
This is Rietveld 408576698