Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: tests/corelib_2/growable_list_test.dart

Issue 2989643002: Migrate test block 8 to Dart 2.0. (Closed)
Patch Set: Merge Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/corelib_2/growable_list_test.dart
diff --git a/tests/corelib_strong/growable_list_test.dart b/tests/corelib_2/growable_list_test.dart
similarity index 95%
rename from tests/corelib_strong/growable_list_test.dart
rename to tests/corelib_2/growable_list_test.dart
index 2aa5b6fa6f761c40969dc6e326a4fd8f1a95d507..355d9cc60ef530dd35c6268b3325a1701fb15d10 100644
--- a/tests/corelib_strong/growable_list_test.dart
+++ b/tests/corelib_2/growable_list_test.dart
@@ -8,11 +8,8 @@ import "package:expect/expect.dart";
void main() {
testConstructor();
-
- bool checked = false;
- assert((checked = true));
// Concurrent modification checks are only guaranteed in checked mode.
- if (checked) testConcurrentModification();
+ testConcurrentModification();
}
// Iterable generating numbers in range [0..count).
@@ -33,7 +30,7 @@ class TestIterable extends TestIterableBase {
int get length => throw "SHOULD NOT BE CALLED";
}
-// Implement Set for private EfficientLength interface.
+// Implement Set for private EfficientLengthIterable interface.
class EfficientTestIterable extends TestIterableBase implements Set<int> {
EfficientTestIterable(length, count, [callbackIndex = -1, callback])
: super(length, count, callbackIndex, callback);
@@ -108,7 +105,7 @@ void testConstructor() {
}
void testConcurrentModification() {
- // Without EfficientLength interface
+ // Without EfficientLengthIterable interface
{
// Change length of list after 200 additions.
var l = [];
@@ -131,7 +128,7 @@ void testConcurrentModification() {
}, (e) => e is ConcurrentModificationError, "cm2");
}
- // With EfficientLength interface (uses length).
+ // With EfficientLengthIterable interface (uses length).
{
// Change length of list after 20 additions.
var l = [];
« no previous file with comments | « tests/corelib_2/from_environment_const_type_undefined_test.dart ('k') | tests/corelib_2/has_next_iterator_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698