Migrate test block 8 to Dart 2.0.

Migrate test block 8 to Dart 2.0.

This was a hairy test block, please review carefully.  Special circumstances:
file_resource_test.dart: deleted, depends on Resource class which was moved outside the SDK
from_environment_const_type_undefined_test.dart, from_environment_const_type_test: change to expect compile-time errors for all error cases.
Hacked up status files to enable non-strong/checked/non-checked modes to work in all cases.
format_exception_test.dart: corelib is newer, has updated tests
growable_list_test.dart: corelib is newer, with updated comments.  Stripped runtime checking of checked mode.  Also, this doesn't work, but should, with dartdevc, so added to exclusion list
hash_map2_test.dart: corelib_strong version seems to be newer, has VM option comments

BUG=
R=rnystrom@google.com

Committed: https://github.com/dart-lang/sdk/commit/328c30324ceeed99880c820f2e4c79c310f6ab32

[jcollins, 2017-07-25 20:39:50]

Description was changed from

==========
Migrate test block 8.

BUG=
==========

to

==========
Migrate test block 8 to Dart 2.0.

This was a hairy test block, please review carefully.  Special circumstances:
file_resource_test.dart: deleted, depends on Resource class which was moved
outside the SDK
from_environment_const_type_undefined_test.dart,
from_environment_const_type_test: change to expect compile-time errors for all
error cases.
Hacked up status files to enable non-strong/checked/non-checked modes to work in
all cases.
format_exception_test.dart: corelib is newer, has updated tests
growable_list_test.dart: corelib is newer, with updated comments.  Doesn't work,
but should, with dartdevc, added to exclusion list
hash_map2_test.dart: corelib_strong version seems to be newer, has VM option
comments

BUG=
==========

[jcollins, 2017-07-25 20:40:43]

jcollins@google.com changed reviewers:
+ bkonyi@google.com, rnystrom@google.com

[jcollins, 2017-07-25 20:40:43]

jcollins@google.com changed required reviewers:
+ rnystrom@google.com

[jcollins, 2017-07-25 20:44:29]

On 2017/07/25 20:40:44, jcollins wrote:

Noticed just now that growable_list_test is checking for checked mode.  Will
strip that in a following patch set.

[jcollins, 2017-07-25 20:52:39]

On 2017/07/25 20:44:29, jcollins wrote:
> On 2017/07/25 20:40:44, jcollins wrote:
> 
> Noticed just now that growable_list_test is checking for checked mode.  Will
> strip that in a following patch set.

PTAL -- growable_list_test is now fixed.

[jcollins, 2017-07-25 20:53:06]

Description was changed from

==========
Migrate test block 8 to Dart 2.0.

This was a hairy test block, please review carefully.  Special circumstances:
file_resource_test.dart: deleted, depends on Resource class which was moved
outside the SDK
from_environment_const_type_undefined_test.dart,
from_environment_const_type_test: change to expect compile-time errors for all
error cases.
Hacked up status files to enable non-strong/checked/non-checked modes to work in
all cases.
format_exception_test.dart: corelib is newer, has updated tests
growable_list_test.dart: corelib is newer, with updated comments.  Doesn't work,
but should, with dartdevc, added to exclusion list
hash_map2_test.dart: corelib_strong version seems to be newer, has VM option
comments

BUG=
==========

to

==========
Migrate test block 8 to Dart 2.0.

This was a hairy test block, please review carefully.  Special circumstances:
file_resource_test.dart: deleted, depends on Resource class which was moved
outside the SDK
from_environment_const_type_undefined_test.dart,
from_environment_const_type_test: change to expect compile-time errors for all
error cases.
Hacked up status files to enable non-strong/checked/non-checked modes to work in
all cases.
format_exception_test.dart: corelib is newer, has updated tests
growable_list_test.dart: corelib is newer, with updated comments.  Stripped
runtime checking of checked mode.  Also, this doesn't work, but should, with
dartdevc, so added to exclusion list
hash_map2_test.dart: corelib_strong version seems to be newer, has VM option
comments

BUG=
==========

[Bob Nystrom, 2017-07-27 00:02:24]

One thing then LGTM.

https://codereview.chromium.org/2989643002/diff/40001/tests/corelib_2/from_en...
File tests/corelib_2/from_environment_const_type_test.dart (right):

https://codereview.chromium.org/2989643002/diff/40001/tests/corelib_2/from_en...
tests/corelib_2/from_environment_const_type_test.dart:12: int //    //# 02:
static type warning, compile-time error
You should be able to change all of the "static type warning, compile-time
error" to just "compile-time error". In Dart 2.0, there's no such thing as a
"static type warning".

https://codereview.chromium.org/2989643002/diff/40001/tests/corelib_2/from_en...
File tests/corelib_2/from_environment_const_type_undefined_test.dart (right):

https://codereview.chromium.org/2989643002/diff/40001/tests/corelib_2/from_en...
tests/corelib_2/from_environment_const_type_undefined_test.dart:11: int //   //#
02: static type warning, compile-time error
Ditto.

[jcollins, 2017-08-02 21:06:12]

https://codereview.chromium.org/2989643002/diff/40001/tests/corelib_2/from_en...
File tests/corelib_2/from_environment_const_type_test.dart (right):

https://codereview.chromium.org/2989643002/diff/40001/tests/corelib_2/from_en...
tests/corelib_2/from_environment_const_type_test.dart:12: int //    //# 02:
static type warning, compile-time error
On 2017/07/27 00:02:24, Bob Nystrom wrote:
> You should be able to change all of the "static type warning, compile-time
> error" to just "compile-time error". In Dart 2.0, there's no such thing as a
> "static type warning".

Analyzer still emits these in many cases it seems.  Are you suggesting that for
dart2analyzer we should file bugs when this happens and use
MissingCompileTimeError?

[Bob Nystrom, 2017-08-02 21:15:18]

lgtm

https://codereview.chromium.org/2989643002/diff/40001/tests/corelib_2/from_en...
File tests/corelib_2/from_environment_const_type_test.dart (right):

https://codereview.chromium.org/2989643002/diff/40001/tests/corelib_2/from_en...
tests/corelib_2/from_environment_const_type_test.dart:12: int //    //# 02:
static type warning, compile-time error
On 2017/08/02 21:06:12, jcollins wrote:
> On 2017/07/27 00:02:24, Bob Nystrom wrote:
> > You should be able to change all of the "static type warning, compile-time
> > error" to just "compile-time error". In Dart 2.0, there's no such thing as a
> > "static type warning".
> 
> Analyzer still emits these in many cases it seems.  Are you suggesting that
for
> dart2analyzer we should file bugs when this happens and use
> MissingCompileTimeError?

We don't need to file bugs. (We'd be filing a *lot* of bugs if we filed one for
every missing Dart 2.0 static error in the various implementations. :) )

But, yes, you'll add MissingCompileTimeError to the status file. By the end of
the migration, there's going to be a *lot* of those in the status files. That's
OK. Once we switch everything to the new front end, those should go away. The
fact that they are in the status files will help us verify that they do go away
with the new front end.

For example, see all of the MissingCompileTimeError lines here:

https://github.com/dart-lang/sdk/blob/master/tests/language_2/language_2.status

[jcollins, 2017-08-02 21:44:05]

https://codereview.chromium.org/2989643002/diff/40001/tests/corelib_2/from_en...
File tests/corelib_2/from_environment_const_type_test.dart (right):

https://codereview.chromium.org/2989643002/diff/40001/tests/corelib_2/from_en...
tests/corelib_2/from_environment_const_type_test.dart:12: int //    //# 02:
static type warning, compile-time error
On 2017/08/02 21:15:18, Bob Nystrom wrote:
> On 2017/08/02 21:06:12, jcollins wrote:
> > On 2017/07/27 00:02:24, Bob Nystrom wrote:
> > > You should be able to change all of the "static type warning, compile-time
> > > error" to just "compile-time error". In Dart 2.0, there's no such thing as
a
> > > "static type warning".
> > 
> > Analyzer still emits these in many cases it seems.  Are you suggesting that
> for
> > dart2analyzer we should file bugs when this happens and use
> > MissingCompileTimeError?
> 
> We don't need to file bugs. (We'd be filing a *lot* of bugs if we filed one
for
> every missing Dart 2.0 static error in the various implementations. :) )
> 
> But, yes, you'll add MissingCompileTimeError to the status file. By the end of
> the migration, there's going to be a *lot* of those in the status files.
That's
> OK. Once we switch everything to the new front end, those should go away. The
> fact that they are in the status files will help us verify that they do go
away
> with the new front end.
> 
> For example, see all of the MissingCompileTimeError lines here:
> 
>
https://github.com/dart-lang/sdk/blob/master/tests/language_2/language_2.status

Done.

https://codereview.chromium.org/2989643002/diff/40001/tests/corelib_2/from_en...
File tests/corelib_2/from_environment_const_type_undefined_test.dart (right):

https://codereview.chromium.org/2989643002/diff/40001/tests/corelib_2/from_en...
tests/corelib_2/from_environment_const_type_undefined_test.dart:11: int //   //#
02: static type warning, compile-time error
On 2017/07/27 00:02:24, Bob Nystrom wrote:
> Ditto.

Done.

[jcollins, 2017-08-03 15:37:53]

Description was changed from

==========
Migrate test block 8 to Dart 2.0.

This was a hairy test block, please review carefully.  Special circumstances:
file_resource_test.dart: deleted, depends on Resource class which was moved
outside the SDK
from_environment_const_type_undefined_test.dart,
from_environment_const_type_test: change to expect compile-time errors for all
error cases.
Hacked up status files to enable non-strong/checked/non-checked modes to work in
all cases.
format_exception_test.dart: corelib is newer, has updated tests
growable_list_test.dart: corelib is newer, with updated comments.  Stripped
runtime checking of checked mode.  Also, this doesn't work, but should, with
dartdevc, so added to exclusion list
hash_map2_test.dart: corelib_strong version seems to be newer, has VM option
comments

BUG=
==========

to

==========
Migrate test block 8 to Dart 2.0.

This was a hairy test block, please review carefully.  Special circumstances:
file_resource_test.dart: deleted, depends on Resource class which was moved
outside the SDK
from_environment_const_type_undefined_test.dart,
from_environment_const_type_test: change to expect compile-time errors for all
error cases.
Hacked up status files to enable non-strong/checked/non-checked modes to work in
all cases.
format_exception_test.dart: corelib is newer, has updated tests
growable_list_test.dart: corelib is newer, with updated comments.  Stripped
runtime checking of checked mode.  Also, this doesn't work, but should, with
dartdevc, so added to exclusion list
hash_map2_test.dart: corelib_strong version seems to be newer, has VM option
comments

BUG=
R=rnystrom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/328c30324ceeed99880c820f2e4c79c310f6ab32
==========

[jcollins, 2017-08-03 15:37:55]

Committed patchset #6 (id:100001) manually as
328c30324ceeed99880c820f2e4c79c310f6ab32 (presubmit successful).