Issue 30238. Fix for subscribing for a notifications with already cached analysis result.

pkg/analysis_server/lib/src/analysis_server.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:core';
 import 'dart:io' as io;
 import 'dart:math' show max;
 
@@ skipping 542 matching lines @@
       return driver;
     }
     return null;
   }
 
   /**
    * Return the analysis result for the file with the given [path]. The file is
    * analyzed in one of the analysis drivers to which the file was added,
    * otherwise in the first driver, otherwise `null` is returned.
    */
-  Future<nd.AnalysisResult> getAnalysisResult(String path) async {
+  Future<nd.AnalysisResult> getAnalysisResult(String path,
+      {bool sendCachedToStream: false}) async {
     if (!AnalysisEngine.isDartFileName(path)) {
       return null;
     }
 
     try {
       nd.AnalysisDriver driver = getAnalysisDriver(path);
-      return await driver?.getResult(path);
+      return await driver?.getResult(path,
+          sendCachedToStream: sendCachedToStream);
     } catch (e) {
       // Ignore the exception.
       // We don't want to log the same exception again and again.
       return null;
     }
   }
 
   /**
    * Return the [AstProvider] for the given [path].
    */
@@ skipping 283 matching lines @@
       notificationManager.setSubscriptions(subscriptions);
     }
     this.analysisServices = subscriptions;
     Set<String> allNewFiles =
         subscriptions.values.expand((files) => files).toSet();
     for (String file in allNewFiles) {
       // The result will be produced by the "results" stream with
       // the fully resolved unit, and processed with sending analysis
       // notifications as it happens after content changes.
       if (AnalysisEngine.isDartFileName(file)) {
-        getAnalysisResult(file);
+        getAnalysisResult(file, sendCachedToStream: true);
       }
     }
   }
 
   /**
    * Implementation for `analysis.setGeneralSubscriptions`.
    */
   void setGeneralAnalysisSubscriptions(
       List<GeneralAnalysisService> subscriptions) {
     Set<GeneralAnalysisService> newServices = subscriptions.toSet();
@@ skipping 609 matching lines @@
   /**
    * The [PerformanceTag] for time spent in server request handlers.
    */
   static PerformanceTag serverRequests = server.createChild('requests');
 
   /**
    * The [PerformanceTag] for time spent in split store microtasks.
    */
   static PerformanceTag splitStore = new PerformanceTag('splitStore');
 }