Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: runtime/vm/assembler_arm64.cc

Issue 298963006: Change COMPILE_ASSERT to take only one argument and use it in more places. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/assembler_arm.cc ('k') | runtime/vm/assembler_ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_ARM64) 6 #if defined(TARGET_ARCH_ARM64)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/cpu.h" 9 #include "vm/cpu.h"
10 #include "vm/longjump.h" 10 #include "vm/longjump.h"
(...skipping 865 matching lines...) Expand 10 before | Expand all | Expand 10 after
876 } 876 }
877 } 877 }
878 878
879 879
880 // Store into object. 880 // Store into object.
881 // Preserves object and value registers. 881 // Preserves object and value registers.
882 void Assembler::StoreIntoObjectFilterNoSmi(Register object, 882 void Assembler::StoreIntoObjectFilterNoSmi(Register object,
883 Register value, 883 Register value,
884 Label* no_update) { 884 Label* no_update) {
885 COMPILE_ASSERT((kNewObjectAlignmentOffset == kWordSize) && 885 COMPILE_ASSERT((kNewObjectAlignmentOffset == kWordSize) &&
886 (kOldObjectAlignmentOffset == 0), young_alignment); 886 (kOldObjectAlignmentOffset == 0));
887 887
888 // Write-barrier triggers if the value is in the new space (has bit set) and 888 // Write-barrier triggers if the value is in the new space (has bit set) and
889 // the object is in the old space (has bit cleared). 889 // the object is in the old space (has bit cleared).
890 // To check that, we compute value & ~object and skip the write barrier 890 // To check that, we compute value & ~object and skip the write barrier
891 // if the bit is not set. We can't destroy the object. 891 // if the bit is not set. We can't destroy the object.
892 bic(TMP, value, Operand(object)); 892 bic(TMP, value, Operand(object));
893 tsti(TMP, kNewObjectAlignmentOffset); 893 tsti(TMP, kNewObjectAlignmentOffset);
894 b(no_update, EQ); 894 b(no_update, EQ);
895 } 895 }
896 896
(...skipping 445 matching lines...) Expand 10 before | Expand all | Expand 10 after
1342 LoadImmediate(TMP, tags, pp); 1342 LoadImmediate(TMP, tags, pp);
1343 StoreFieldToOffset(TMP, instance_reg, Object::tags_offset(), pp); 1343 StoreFieldToOffset(TMP, instance_reg, Object::tags_offset(), pp);
1344 } else { 1344 } else {
1345 b(failure); 1345 b(failure);
1346 } 1346 }
1347 } 1347 }
1348 1348
1349 } // namespace dart 1349 } // namespace dart
1350 1350
1351 #endif // defined TARGET_ARCH_ARM64 1351 #endif // defined TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « runtime/vm/assembler_arm.cc ('k') | runtime/vm/assembler_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698