Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Side by Side Diff: runtime/vm/assembler_arm.cc

Issue 298963006: Change COMPILE_ASSERT to take only one argument and use it in more places. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/platform/assert.h ('k') | runtime/vm/assembler_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/cpu.h" 9 #include "vm/cpu.h"
10 #include "vm/longjump.h" 10 #include "vm/longjump.h"
(...skipping 1569 matching lines...) Expand 10 before | Expand all | Expand 10 after
1580 cmp(rn, ShifterOperand(IP)); 1580 cmp(rn, ShifterOperand(IP));
1581 } 1581 }
1582 } 1582 }
1583 1583
1584 1584
1585 // Preserves object and value registers. 1585 // Preserves object and value registers.
1586 void Assembler::StoreIntoObjectFilterNoSmi(Register object, 1586 void Assembler::StoreIntoObjectFilterNoSmi(Register object,
1587 Register value, 1587 Register value,
1588 Label* no_update) { 1588 Label* no_update) {
1589 COMPILE_ASSERT((kNewObjectAlignmentOffset == kWordSize) && 1589 COMPILE_ASSERT((kNewObjectAlignmentOffset == kWordSize) &&
1590 (kOldObjectAlignmentOffset == 0), young_alignment); 1590 (kOldObjectAlignmentOffset == 0));
1591 1591
1592 // Write-barrier triggers if the value is in the new space (has bit set) and 1592 // Write-barrier triggers if the value is in the new space (has bit set) and
1593 // the object is in the old space (has bit cleared). 1593 // the object is in the old space (has bit cleared).
1594 // To check that, we compute value & ~object and skip the write barrier 1594 // To check that, we compute value & ~object and skip the write barrier
1595 // if the bit is not set. We can't destroy the object. 1595 // if the bit is not set. We can't destroy the object.
1596 bic(IP, value, ShifterOperand(object)); 1596 bic(IP, value, ShifterOperand(object));
1597 tst(IP, ShifterOperand(kNewObjectAlignmentOffset)); 1597 tst(IP, ShifterOperand(kNewObjectAlignmentOffset));
1598 b(no_update, EQ); 1598 b(no_update, EQ);
1599 } 1599 }
1600 1600
(...skipping 1609 matching lines...) Expand 10 before | Expand all | Expand 10 after
3210 3210
3211 3211
3212 const char* Assembler::FpuRegisterName(FpuRegister reg) { 3212 const char* Assembler::FpuRegisterName(FpuRegister reg) {
3213 ASSERT((0 <= reg) && (reg < kNumberOfFpuRegisters)); 3213 ASSERT((0 <= reg) && (reg < kNumberOfFpuRegisters));
3214 return fpu_reg_names[reg]; 3214 return fpu_reg_names[reg];
3215 } 3215 }
3216 3216
3217 } // namespace dart 3217 } // namespace dart
3218 3218
3219 #endif // defined TARGET_ARCH_ARM 3219 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/platform/assert.h ('k') | runtime/vm/assembler_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698