Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: ui/app_list/cocoa/apps_grid_controller_unittest.mm

Issue 298963004: app_list: Fix possible out of bounds index. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: DCHECK -> CHECK Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/app_list/test/app_list_test_model.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/cocoa/apps_grid_controller_unittest.mm
diff --git a/ui/app_list/cocoa/apps_grid_controller_unittest.mm b/ui/app_list/cocoa/apps_grid_controller_unittest.mm
index 13634d818b9938cf7cb6c913d43cdb04a9e22d1c..fdb5e60f6b936bb4a1de3a0ba144e2f3c908feaa 100644
--- a/ui/app_list/cocoa/apps_grid_controller_unittest.mm
+++ b/ui/app_list/cocoa/apps_grid_controller_unittest.mm
@@ -454,6 +454,7 @@ TEST_F(AppsGridControllerTest, ModelUpdate) {
EXPECT_NSEQ(@"UpdatedItem", [button title]);
// Test icon updates through the model observer by ensuring the icon changes.
+ item_model->SetIcon(gfx::ImageSkia(), false);
NSSize icon_size = [[button image] size];
EXPECT_EQ(0, icon_size.width);
EXPECT_EQ(0, icon_size.height);
« no previous file with comments | « no previous file | ui/app_list/test/app_list_test_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698