Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Unified Diff: Source/core/html/HTMLInputElement.cpp

Issue 298963003: Oilpan: Move ClickHandlingState to heap (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Added FINAL Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/html/forms/CheckboxInputType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLInputElement.cpp
diff --git a/Source/core/html/HTMLInputElement.cpp b/Source/core/html/HTMLInputElement.cpp
index 44ac76f3512e9253f08bc5c2382ab475941a5fd7..e2b62c84e9e458c58c998921d6afaf863190cabf 100644
--- a/Source/core/html/HTMLInputElement.cpp
+++ b/Source/core/html/HTMLInputElement.cpp
@@ -1090,13 +1090,17 @@ void* HTMLInputElement::preDispatchEventHandler(Event* event)
return 0;
if (!event->isMouseEvent() || toMouseEvent(event)->button() != LeftButton)
return 0;
+#if ENABLE(OILPAN)
+ return m_inputTypeView->willDispatchClick();
+#else
// FIXME: Check whether there are any cases where this actually ends up leaking.
return m_inputTypeView->willDispatchClick().leakPtr();
haraken 2014/05/22 10:44:50 Shall we add RawPtr::leakPtr so that we don't need
+#endif
}
void HTMLInputElement::postDispatchEventHandler(Event* event, void* dataFromPreDispatch)
{
- OwnPtr<ClickHandlingState> state = adoptPtr(static_cast<ClickHandlingState*>(dataFromPreDispatch));
+ OwnPtrWillBeRawPtr<ClickHandlingState> state = adoptPtrWillBeNoop(static_cast<ClickHandlingState*>(dataFromPreDispatch));
if (!state)
return;
m_inputTypeView->didDispatchClick(event, *state);
« no previous file with comments | « no previous file | Source/core/html/forms/CheckboxInputType.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698