Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2989623002: Pin the dev SDK version pulled by Fuchsia (Closed)

Created:
3 years, 5 months ago by zra
Modified:
3 years, 5 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Pin the dev SDK version pulled by Fuchsia Committed: https://github.com/dart-lang/sdk/commit/c1ddf2a0aee93ecff3c93621d64d676d0ed49cec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/download_latest_dev_sdk.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
TBR
3 years, 5 months ago (2017-07-25 16:09:05 UTC) #2
zra
Committed patchset #1 (id:1) manually as c1ddf2a0aee93ecff3c93621d64d676d0ed49cec (presubmit successful).
3 years, 5 months ago (2017-07-25 16:12:55 UTC) #4
rmacnak
3 years, 5 months ago (2017-07-25 16:42:18 UTC) #5
Message was sent while issue was closed.
lgtm

We should consider having the Fuchsia manifest pass a revision to this script,
probably matching the revision of //dart.

Powered by Google App Engine
This is Rietveld 408576698