Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Unified Diff: runtime/vm/object.cc

Issue 2989563002: Preserve type variables in closure conversion. (Closed)
Patch Set: Visit more children, review comments. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/testcases/closures_type_vars/type_variables.dart.expect ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index 248622662a4be3a742e84099c3c422939abaa036..a1589b10fab3964d3eb9e98988dbc78b4fb82a8f 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -6878,7 +6878,7 @@ void Function::DropUncompiledImplicitClosureFunction() const {
// Converted closure functions are used in VM Closure instances that represent
// the results of evaluation of [MakeClosure] primitive operations.
//
-// Internally, converted closure functins are represented with the same Closure
+// Internally, converted closure functions are represented with the same Closure
// class as implicit closure functions (that are used for dealing with
// tear-offs). The Closure class instances have two fields, one for the
// function, and one for the captured context. Implicit closure functions have
@@ -6902,7 +6902,7 @@ void Function::DropUncompiledImplicitClosureFunction() const {
// this way, is invoked, it should receive the [Vector] as the first argument,
// and take the rest of the arguments from the invocation.
//
-// Converted cosure functions in VM follow same discipline as implicit closure
+// Converted closure functions in VM follow same discipline as implicit closure
// functions, because they are similar in many ways. For further deatils, please
// refer to the following methods:
// -> Function::ConvertedClosureFunction
« no previous file with comments | « pkg/kernel/testcases/closures_type_vars/type_variables.dart.expect ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698