Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: pkg/kernel/test/closures/suite.dart

Issue 2989563002: Preserve type variables in closure conversion. (Closed)
Patch Set: Visit more children, review comments. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/kernel/test/closures/suite.dart
diff --git a/pkg/kernel/test/closures/suite.dart b/pkg/kernel/test/closures/suite.dart
index 9748f3acda9c3c73f959d5f305d6b80d522cca6a..84d288894a026844a690cd6baefd566e593dbaf7 100644
--- a/pkg/kernel/test/closures/suite.dart
+++ b/pkg/kernel/test/closures/suite.dart
@@ -60,8 +60,7 @@ class ClosureConversionContext extends ChainContext implements CompileContext {
];
static Future<ClosureConversionContext> create(
- Chain suite, Map<String, String> environment) async {
- bool strongMode = environment.containsKey(STRONG_MODE);
+ Chain suite, Map<String, String> environment, bool strongMode) async {
bool updateExpectations = environment["updateExpectations"] == "true";
return new ClosureConversionContext(strongMode, updateExpectations);
}
@@ -69,9 +68,10 @@ class ClosureConversionContext extends ChainContext implements CompileContext {
Future<ClosureConversionContext> createContext(
Chain suite, Map<String, String> environment) async {
+ bool strongMode = environment.containsKey(STRONG_MODE);
environment["updateExpectations"] =
const String.fromEnvironment("updateExpectations");
- return ClosureConversionContext.create(suite, environment);
+ return ClosureConversionContext.create(suite, environment, strongMode);
}
class ClosureConversion
« no previous file with comments | « pkg/kernel/lib/transformations/closure/info.dart ('k') | pkg/kernel/test/closures_type_vars/closures_type_vars.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698