Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: chrome/browser/web_applications/web_app_mac.mm

Issue 298953002: Remove --disable-app-shims. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Don't check disableCreateAppShortcut on NTP. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_applications/web_app_mac.mm
diff --git a/chrome/browser/web_applications/web_app_mac.mm b/chrome/browser/web_applications/web_app_mac.mm
index 563b33f76c3e506877c147d9b9cb4ca15cc43c53..3a7b237f1f4e34fa21c738e9af121cd5470ece5f 100644
--- a/chrome/browser/web_applications/web_app_mac.mm
+++ b/chrome/browser/web_applications/web_app_mac.mm
@@ -7,7 +7,6 @@
#import <Carbon/Carbon.h>
#import <Cocoa/Cocoa.h>
-#include "apps/app_shim/app_shim_mac.h"
#include "base/command_line.h"
#include "base/file_util.h"
#include "base/files/file_enumerator.h"
@@ -137,6 +136,12 @@ bool AddGfxImageToIconFamily(IconFamilyHandle icon_family,
return result == noErr;
}
+bool AppShimsDisabledForTest() {
+ // Disable app shims in tests because shims created in ~/Applications will not
+ // be cleaned up.
+ return CommandLine::ForCurrentProcess()->HasSwitch(switches::kTestType);
+}
+
base::FilePath GetWritableApplicationsDirectory() {
base::FilePath path;
if (base::mac::GetUserDirectory(NSApplicationDirectory, &path)) {
@@ -849,7 +854,7 @@ base::FilePath GetAppInstallPath(const ShortcutInfo& shortcut_info) {
}
void MaybeLaunchShortcut(const ShortcutInfo& shortcut_info) {
- if (!apps::IsAppShimsEnabled())
+ if (AppShimsDisabledForTest())
return;
content::BrowserThread::PostTask(
@@ -919,6 +924,9 @@ bool CreatePlatformShortcuts(
const ShortcutLocations& creation_locations,
ShortcutCreationReason creation_reason) {
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
+ if (AppShimsDisabledForTest())
+ return true;
+
WebAppShortcutCreator shortcut_creator(
app_data_path, shortcut_info, file_handlers_info);
return shortcut_creator.CreateShortcuts(creation_reason, creation_locations);
@@ -938,6 +946,9 @@ void UpdatePlatformShortcuts(
const ShortcutInfo& shortcut_info,
const extensions::FileHandlersInfo& file_handlers_info) {
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
+ if (AppShimsDisabledForTest())
+ return;
+
WebAppShortcutCreator shortcut_creator(
app_data_path, shortcut_info, file_handlers_info);
shortcut_creator.UpdateShortcuts();

Powered by Google App Engine
This is Rietveld 408576698