Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: apps/app_shim/app_shim_mac.cc

Issue 298953002: Remove --disable-app-shims. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/app/generated_resources.grd » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "apps/app_shim/app_shim_mac.h" 5 #include "apps/app_shim/app_shim_mac.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "chrome/common/chrome_switches.h" 8 #include "chrome/common/chrome_switches.h"
9 9
10 namespace apps { 10 namespace apps {
11 11
12 bool IsAppShimsEnabled() { 12 bool IsAppShimsEnabled() {
13 // Disable app shims in tests because shims created in ~/Applications will not 13 // Disable app shims in tests because shims created in ~/Applications will not
14 // be cleaned up. 14 // be cleaned up.
tapted 2014/05/22 04:11:11 Is this the only reason? That is, can we move this
jackhou1 2014/05/22 04:59:58 Hmm, when I was considering this, I thought it was
15 return !(CommandLine::ForCurrentProcess()->HasSwitch(switches::kTestType) || 15 return !CommandLine::ForCurrentProcess()->HasSwitch(switches::kTestType);
16 CommandLine::ForCurrentProcess()->HasSwitch(switches::kDisableAppShims));
17 } 16 }
18 17
19 } // namespace apps 18 } // namespace apps
OLDNEW
« no previous file with comments | « no previous file | chrome/app/generated_resources.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698