Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2989473002: Migrated test block 27 to Dart 2.0. (Closed)

Created:
3 years, 5 months ago by bkonyi
Modified:
3 years, 4 months ago
Reviewers:
Bob Nystrom, jcollins
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrated test block 27 to Dart 2.0. Relatively simple block. Split string_base_vm_test into string_base_vm_static_test and string_base_vm_test, updated status files. BUG= R=jcollins@google.com, rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/c3eb9657203421239e3ea4abc1c2472ba37403ff

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed Bob's nits and fixed test failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1620 lines) Patch
M tests/corelib/corelib.status View 7 chunks +0 lines, -19 lines 0 comments Download
D tests/corelib/stacktrace_fromstring_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D tests/corelib/stopwatch2_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/corelib/stopwatch_test.dart View 1 chunk +0 lines, -128 lines 0 comments Download
D tests/corelib/string_base_vm_test.dart View 1 chunk +0 lines, -83 lines 0 comments Download
D tests/corelib/string_buffer_test.dart View 1 chunk +0 lines, -239 lines 0 comments Download
D tests/corelib/string_case_test.dart View 1 chunk +0 lines, -55 lines 0 comments Download
D tests/corelib/string_codeunits_test.dart View 1 chunk +0 lines, -80 lines 0 comments Download
D tests/corelib/string_from_environment2_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D tests/corelib/string_from_environment3_test.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/corelib/string_from_environment_test.dart View 1 chunk +0 lines, -13 lines 0 comments Download
D tests/corelib/string_from_list_test.dart View 1 chunk +0 lines, -84 lines 0 comments Download
D tests/corelib/string_fromcharcode_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 1 4 chunks +29 lines, -0 lines 0 comments Download
A + tests/corelib_2/stacktrace_fromstring_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/stopwatch2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/stopwatch_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/corelib_2/string_base_vm_static_test.dart View 1 1 chunk +10 lines, -0 lines 0 comments Download
A + tests/corelib_2/string_base_vm_test.dart View 1 chunk +0 lines, -9 lines 0 comments Download
A + tests/corelib_2/string_buffer_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/string_case_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/string_codeunits_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/string_from_environment2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/string_from_environment3_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/string_from_environment_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/string_from_list_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + tests/corelib_2/string_fromcharcode_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/corelib_strong/corelib_strong.status View 2 chunks +0 lines, -5 lines 0 comments Download
D tests/corelib_strong/stacktrace_fromstring_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D tests/corelib_strong/stopwatch2_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/corelib_strong/stopwatch_test.dart View 1 chunk +0 lines, -128 lines 0 comments Download
D tests/corelib_strong/string_base_vm_test.dart View 1 chunk +0 lines, -83 lines 0 comments Download
D tests/corelib_strong/string_buffer_test.dart View 1 chunk +0 lines, -239 lines 0 comments Download
D tests/corelib_strong/string_case_test.dart View 1 chunk +0 lines, -55 lines 0 comments Download
D tests/corelib_strong/string_codeunits_test.dart View 1 chunk +0 lines, -80 lines 0 comments Download
D tests/corelib_strong/string_from_environment2_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D tests/corelib_strong/string_from_environment3_test.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/corelib_strong/string_from_environment_test.dart View 1 chunk +0 lines, -13 lines 0 comments Download
D tests/corelib_strong/string_from_list_test.dart View 1 chunk +0 lines, -84 lines 0 comments Download
D tests/corelib_strong/string_fromcharcode_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bkonyi
3 years, 5 months ago (2017-07-21 18:23:42 UTC) #2
jcollins
LGTM, be sure to test --checked mode
3 years, 5 months ago (2017-07-21 19:15:51 UTC) #3
Bob Nystrom
lgtm https://codereview.chromium.org/2989473002/diff/1/tests/corelib_2/string_base_vm_static_test.dart File tests/corelib_2/string_base_vm_static_test.dart (right): https://codereview.chromium.org/2989473002/diff/1/tests/corelib_2/string_base_vm_static_test.dart#newcode9 tests/corelib_2/string_base_vm_static_test.dart:9: String s4 = new String.fromCharCodes([0.0]); /*@compile-error=unspecified*/ Nit: I'd ...
3 years, 5 months ago (2017-07-21 23:00:32 UTC) #4
bkonyi
3 years, 5 months ago (2017-07-24 19:43:36 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
c3eb9657203421239e3ea4abc1c2472ba37403ff.

Powered by Google App Engine
This is Rietveld 408576698