Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Issue 2989433002: Revert "D8 roll with 'Avoid using D8 Worker'" (Closed)

Created:
3 years, 5 months ago by sra1
Modified:
3 years, 5 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "D8 roll with 'Avoid using D8 Worker'" This reverts commit 487a9048fdf857da7e8fdbf5e7bd15861b241901. Failed on Golem, all benchmarks show "Run Failed". Perhaps there are missing .so files on the runners. TBR=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/4790e3c842b9469c5b6df37f4b958b426fdcadd5

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -22 lines) Patch
M sdk/lib/_internal/js_runtime/lib/preambles/d8.js View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +1 line, -1 line 0 comments Download
M third_party/d8/README.google View 1 chunk +6 lines, -10 lines 0 comments Download
M third_party/d8/linux/d8.sha1 View 1 chunk +1 line, -1 line 0 comments Download
A third_party/d8/linux/d8-arm.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/d8/linux/natives_blob.bin.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/d8/linux/snapshot_blob.bin.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/d8/windows/d8.exe.sha1 View 1 chunk +1 line, -1 line 0 comments Download
D third_party/d8/windows/natives_blob.bin.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/d8/windows/snapshot_blob.bin.sha1 View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (5 generated)
sra1
3 years, 5 months ago (2017-07-20 23:05:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4790e3c842b9469c5b6df37f4b958b426fdcadd5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698