Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1296)

Unified Diff: common/gcloud/pubsub/topic.go

Issue 2989333002: [logdog] Replace Tumble with push queues. (Closed)
Patch Set: comments Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « common/gcloud/pubsub/publisher.go ('k') | logdog/api/endpoints/coordinator/services/v1/pb.discovery.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: common/gcloud/pubsub/topic.go
diff --git a/common/gcloud/pubsub/topic.go b/common/gcloud/pubsub/topic.go
index 262e6d6ad9e6b4169d9b02b50ac45c7e9351adfa..e10e95ce9c8a7a195585500ff522fb83913933e8 100644
--- a/common/gcloud/pubsub/topic.go
+++ b/common/gcloud/pubsub/topic.go
@@ -16,8 +16,6 @@ package pubsub
import (
"flag"
-
- "cloud.google.com/go/pubsub"
)
// Topic is a fully-qualified Pub/Sub project/topic name.
@@ -61,17 +59,3 @@ func (t Topic) SplitErr() (p, n string, err error) {
p, n, err = resourceProjectName(string(t))
return
}
-
-// DisableTopicBundling configures a new pubsub.Topic to not bundle its data.
-//
-// t must NOT have had any Publish calls made yet, else these settings will not
-// have any effect.
-//
-// By default, a Pub/Sub Topic bundles data, delaying its actual dispatch in
-// favor of batching calls. Sometimes this is not desired. This function
-// configures an existing Topic not to bundle.
-func DisableTopicBundling(t *pubsub.Topic) {
- t.PublishSettings.DelayThreshold = 0
- t.PublishSettings.NumGoroutines = 1
- t.PublishSettings.CountThreshold = 1
-}
« no previous file with comments | « common/gcloud/pubsub/publisher.go ('k') | logdog/api/endpoints/coordinator/services/v1/pb.discovery.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698