webrtc/modules/video_coding/frame_object.cc - Issue 2989313003: Reland of Fix off-by-one bugs in PacketBuffer when the buffer is filled with a single frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/frame_object.cc

Issue 2989313003: Reland of Fix off-by-one bugs in PacketBuffer when the buffer is filled with a single frame. (Closed)

Patch Set: Memcpy fix Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/frame_object.cc

diff --git a/webrtc/modules/video_coding/frame_object.cc b/webrtc/modules/video_coding/frame_object.cc

index 4c4537cb450fc28c68b005cef4a31da4420d7076..25d0e29d218c1538c89637e783d402993bf18020 100644

--- a/webrtc/modules/video_coding/frame_object.cc

+++ b/webrtc/modules/video_coding/frame_object.cc

@@ -93,7 +93,8 @@ RtpFrameObject::RtpFrameObject(PacketBuffer* packet_buffer,

frame_type_ = first_packet->frameType;

}

- GetBitstream(_buffer);

+ bool bitstream_copied = GetBitstream(_buffer);

+ RTC_DCHECK(bitstream_copied);

_encodedWidth = first_packet->width;

_encodedHeight = first_packet->height;