Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Issue 2989283002: [vm] Higher vm snapshot symbol table load factor (Closed)

Created:
3 years, 4 months ago by zra
Modified:
3 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[vm] Higher vm snapshot symbol table load factor This saves a bit less than 100KB in memory footprint in hello world on Fuchsia's content handler: 3640KB -> 3552KB R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/c4b821cc813cd48e0584da7d5afffa74629025c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M runtime/vm/symbols.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
Need to submit a Golem run, still.
3 years, 4 months ago (2017-08-02 18:07:20 UTC) #2
rmacnak
LGTM
3 years, 4 months ago (2017-08-04 01:00:35 UTC) #3
zra
3 years, 4 months ago (2017-08-04 16:22:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c4b821cc813cd48e0584da7d5afffa74629025c6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698